Add an app_shell_unittests target

For now this uses extensions_unittests_main.cc as there are no differences
in startup between extensions_unittests and app_shell_unittests.

This allows ShellNaClBrowserDelegate to have a test.

BUG=402612
TEST=app_shell_unittests

Review URL: https://codereview.chromium.org/471453003

Cr-Commit-Position: refs/heads/master@{#290719}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290719 0039d316-1c4b-4281-b951-d872f2087c98

extensions/BUILD.gn

@@ -61,9 +61,16 @@ source_set("test_support") {
     "common/value_builder.h",
     "renderer/test_extensions_renderer_client.cc",
     "renderer/test_extensions_renderer_client.h",
-  ]
+    "test/test_extensions_client.cc",
+    "test/test_extensions_client.h",
+    "test/test_permission_message_provider.cc",
+    "test/test_permission_message_provider.h",
+    "test/test_permissions_provider.cc",
+    "test/test_permissions_provider.h",
+   ]
 
   deps = [
+    ":extensions_resources",
     "//base",
     "//extensions/browser",
     "//extensions/common",
@@ -155,13 +162,7 @@ test("unittests") {
     "renderer/script_context_set_unittest.cc",
     "renderer/utils_unittest.cc",
     "test/extensions_unittests_main.cc",
-    "test/test_extensions_client.cc",
-    "test/test_extensions_client.h",
-    "test/test_permission_message_provider.cc",
-    "test/test_permission_message_provider.h",
-    "test/test_permissions_provider.cc",
-    "test/test_permissions_provider.h",
-  ]
+ ]
 
   deps = [
     ":extensions_resources",

extensions/extensions.gyp

@@ -741,6 +741,7 @@
         'common/api/api.gyp:extensions_api',
         'extensions_browser',
         'extensions_common',
+        'extensions_resources.gyp:extensions_resources',
       ],
       'include_dirs': [
         '..',
@@ -769,6 +770,12 @@
         'common/value_builder.h',
         'renderer/test_extensions_renderer_client.cc',
         'renderer/test_extensions_renderer_client.h',
+        'test/test_extensions_client.cc',
+        'test/test_extensions_client.h',
+        'test/test_permission_message_provider.cc',
+        'test/test_permission_message_provider.h',
+        'test/test_permissions_provider.cc',
+        'test/test_permissions_provider.h',
       ],
       # Disable c4267 warnings until we fix size_t to int truncations.
       'msvs_disabled_warnings': [ 4267, ],
@@ -906,12 +913,6 @@
         'renderer/script_context_set_unittest.cc',
         'renderer/utils_unittest.cc',
         'test/extensions_unittests_main.cc',
-        'test/test_extensions_client.cc',
-        'test/test_extensions_client.h',
-        'test/test_permission_message_provider.cc',
-        'test/test_permission_message_provider.h',
-        'test/test_permissions_provider.cc',
-        'test/test_permissions_provider.h',
       ],
       # Disable c4267 warnings until we fix size_t to int truncations.
       'msvs_disabled_warnings': [ 4267, ],

extensions/shell/app_shell.gyp

@@ -183,6 +183,24 @@
         'test/shell_tests_main.cc',
       ],
     },
+    {
+      'target_name': 'app_shell_unittests',
+      'type': 'executable',
+      'dependencies': [
+        'app_shell_lib',
+        '<(DEPTH)/base/base.gyp:base',
+        '<(DEPTH)/base/base.gyp:test_support_base',
+        '<(DEPTH)/content/content.gyp:content_app_both',
+        '<(DEPTH)/content/content_shell_and_tests.gyp:test_support_content',
+        '<(DEPTH)/extensions/extensions.gyp:extensions_shell_and_test_pak',
+        '<(DEPTH)/extensions/extensions.gyp:extensions_test_support',
+        '<(DEPTH)/testing/gtest.gyp:gtest',
+      ],
+      'sources': [
+        '../test/extensions_unittests_main.cc',
+        'browser/shell_nacl_browser_delegate_unittest.cc',
+      ],
+    },
     {
       'target_name': 'app_shell_version_header',
       'type': 'none',

extensions/shell/browser/shell_nacl_browser_delegate_unittest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/shell/browser/shell_nacl_browser_delegate.h"
+
+#include "base/strings/string_util.h"
+#include "content/public/test/test_browser_context.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+typedef testing::Test ShellNaClBrowserDelegateTest;
+
+// Verifies that the returned version string has a valid format.
+TEST_F(ShellNaClBrowserDelegateTest, VersionString) {
+  content::TestBrowserContext browser_context;
+  ShellNaClBrowserDelegate delegate(&browser_context);
+
+  // Version should look like "1.2.3.4 (5)".
+  std::string version = delegate.GetVersionString();
+  EXPECT_TRUE(MatchPattern(version, "*.*.*.* (*)")) << "bad version "
+                                                    << version;
+}
+
+}  // namespace extensions