[CrOS PhoneHub] Hook up quick actions UI to controllers. (Reland)

This is a reland CL for crrev/c/2419552, which ran into a compilation failure and merge conflict when reland.

In this CL:
- Create a base class for quick actions controller.
- Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states.
- Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL.

BUG=1106937,1126208

Change-Id: Ie8540bdc29de8b73297dcf5c3f0a0d963f76d63d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438590
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812338}

ash/BUILD.gn

@@ -1145,8 +1145,13 @@ component("ash") {
     "system/phonehub/phone_hub_view_ids.h",
     "system/phonehub/phone_status_view.cc",
     "system/phonehub/phone_status_view.h",
+    "system/phonehub/quick_action_controller_base.h",
+    "system/phonehub/quick_action_item.cc",
+    "system/phonehub/quick_action_item.h",
     "system/phonehub/quick_actions_view.cc",
     "system/phonehub/quick_actions_view.h",
+    "system/phonehub/silence_phone_quick_action_controller.cc",
+    "system/phonehub/silence_phone_quick_action_controller.h",
     "system/phonehub/task_continuation_view.cc",
     "system/phonehub/task_continuation_view.h",
     "system/power/backlights_forced_off_setter.cc",
@@ -2131,6 +2136,7 @@ test("ash_unittests") {
     "system/phonehub/phone_hub_tray_unittest.cc",
     "system/phonehub/phone_hub_ui_controller_unittest.cc",
     "system/phonehub/phone_status_view_unittest.cc",
+    "system/phonehub/quick_actions_view_unittest.cc",
     "system/phonehub/task_continuation_view_unittest.cc",
     "system/power/backlights_forced_off_setter_unittest.cc",
     "system/power/peripheral_battery_notifier_unittest.cc",

ash/ash_strings.grd

@@ -553,7 +553,7 @@ This file contains the strings for ash.
         <ph name="UPDATE_TEXT">$1<ex>Learn more about the latest Chromium OS update</ex></ph>. This Chromebook needs to restart to apply an update. This can take up to 1 minute.
       </message>
       <message name="IDS_DIALOG_TITLE_SLOW_BOOT" desc="The title of the Slow Boot Shutdown Confirmation Dialog.">
-	Restart may take awhile
+        Restart may take awhile
       </message>
       <message name="IDS_DIALOG_MESSAGE_SLOW_BOOT" desc="The body of the Slow Boot Shutdown Confirmation Dialog.">
         Your screen will go blank for longer than usual (up to a minute) during this update. Please don't press the power button while the update is in progress.
@@ -1020,12 +1020,36 @@ This file contains the strings for ash.
       <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_DISABLED_STATE_TOOLTIP" desc="The tooltip text indicating the quick actions feature is off.">
         <ph name="FEATURE_NAME">$1<ex>Silence</ex></ph> is off.
       </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTING_STATE_TOOLTIP" desc="The tooltip text indicating the quick actions feature is currently sending a signal and try to connect to the phone.">
+        <ph name="FEATURE_NAME">$1<ex>Silence</ex></ph> is connecting.
+      </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_CONNECTED_STATE_TOOLTIP" desc="The tooltip text indicating the quick actions feature is not available to use.">
+        <ph name="FEATURE_NAME">$1<ex>Enable Hotspot</ex></ph> is not connected.
+      </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTED_STATE_TOOLTIP" desc="The tooltip text indicating the quick actions feature is not available to use.">
+        <ph name="FEATURE_NAME">$1<ex>Enable Hotspot</ex></ph> is connected.
+      </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_AVAILABLE_STATE_TOOLTIP" desc="The tooltip text indicating the quick actions feature is not available to use.">
+        <ph name="FEATURE_NAME">$1<ex>Silence</ex></ph> is not available.
+      </message>
       <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_OFF_STATE" desc="Quick actions state in phone hub bubble." meaning="Quick actions feature is off.">
         Off
       </message>
       <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_ON_STATE" desc="Quick actions state in phone hub bubble." meaning="Quick actions feature is on.">
         On
       </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTING_STATE" desc="Quick actions state in phone hub bubble." meaning="The feature is currently sending a signal and try to connect to the phone.">
+        Connecting...
+      </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_CONNECTED_STATE" desc="Quick actions state in phone hub bubble." meaning="The feature is not connected to the phone.">
+        Not connected
+      </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTED_STATE" desc="Quick actions state in phone hub bubble." meaning="The feature is connected to the phone and ready to use.">
+        Connected
+      </message>
+      <message name="IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_AVAILABLE_STATE" desc="Quick actions state in phone hub bubble." meaning="Quick actions feature is not available to use.">
+        Not available
+      </message>
       <message name="IDS_ASH_PHONE_HUB_TASK_CONTINUATION_TITLE" desc="Title of the task continuation section (where users pick up unfinished task left off from their phone, currently only support web browsing) in phone hub bubble.">
         Continue browsing
       </message>

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTED_STATE.png.sha1

+f0d2cf8683111c43c0a742492d5e39b3ba128631
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTED_STATE_TOOLTIP.png.sha1

+b7c6650a313b1c1e797821eccc2feb7c957ad091
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTING_STATE.png.sha1

+cf8fe0079e4e717981ba3a9afedf9280cb6d8fda
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTING_STATE_TOOLTIP.png.sha1

+7de2e334fd462e24075fa72eabd0eb3b73e4f13f
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_AVAILABLE_STATE.png.sha1

+918d925ef3041ef720077971df3a0d47bed5cc34
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_AVAILABLE_STATE_TOOLTIP.png.sha1

+ddc04194dd9844eadd4d78cb7d05c8b85ba754e6
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_CONNECTED_STATE.png.sha1

+6d96fd17f94b220d46d0089f65c39d78eb35e6bf
\ No newline at end of file

ash/ash_strings_grd/IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_CONNECTED_STATE_TOOLTIP.png.sha1

+36477329435864bf81335bffbb895daf3f860257
\ No newline at end of file

ash/system/phonehub/phone_connected_view.cc

@@ -49,7 +49,8 @@ PhoneConnectedView::PhoneConnectedView(
     AddChildView(std::make_unique<NotificationOptInView>(bubble_view));
   }
 
-  setup_layered_view(AddChildView(std::make_unique<QuickActionsView>()));
+  setup_layered_view(
+      AddChildView(std::make_unique<QuickActionsView>(phone_hub_manager)));
 
   AddSeparator();
 

ash/system/phonehub/quick_action_controller_base.h

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SYSTEM_PHONEHUB_QUICK_ACTION_CONTROLLER_BASE_H_
+#define ASH_SYSTEM_PHONEHUB_QUICK_ACTION_CONTROLLER_BASE_H_
+
+#include "ash/ash_export.h"
+#include "ash/system/phonehub/quick_action_item.h"
+
+namespace ash {
+
+class QuickActionItem;
+
+// Base class for controllers of quick action item.
+// To add a new quick action item, implement this class, and add to the list in
+// QuickActionsView::InitQuickActionItems().
+class ASH_EXPORT QuickActionControllerBase : public QuickActionItem::Delegate {
+ public:
+  virtual ~QuickActionControllerBase() = default;
+
+  // Create the view. Subclasses instantiate QuickActionItem.
+  // The view will be owned by views hierarchy. The view will be always deleted
+  // after the controller is destructed.
+  virtual QuickActionItem* CreateItem() = 0;
+};
+
+}  // namespace ash
+
+#endif  // ASH_SYSTEM_PHONEHUB_QUICK_ACTION_CONTROLLER_BASE_H_

ash/system/phonehub/quick_action_item.cc

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/system/phonehub/quick_action_item.h"
+
+#include "ash/resources/vector_icons/vector_icons.h"
+#include "ash/strings/grit/ash_strings.h"
+#include "ash/style/ash_color_provider.h"
+#include "ash/system/tray/tray_constants.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/layout/box_layout.h"
+
+namespace ash {
+
+namespace {
+
+constexpr int kQuickActionItemLabelSize = 14;
+
+void ConfigureLabel(views::Label* label, bool is_primary) {
+  label->SetAutoColorReadabilityEnabled(false);
+  label->SetSubpixelRenderingEnabled(false);
+  label->SetCanProcessEventsWithinSubtree(false);
+
+  auto type = is_primary
+                  ? AshColorProvider::ContentLayerType::kTextColorPrimary
+                  : AshColorProvider::ContentLayerType::kTextColorSecondary;
+  label->SetEnabledColor(AshColorProvider::Get()->GetContentLayerColor(type));
+
+  gfx::Font default_font;
+  gfx::Font label_font = default_font.Derive(
+      kQuickActionItemLabelSize - default_font.GetFontSize(), gfx::Font::NORMAL,
+      gfx::Font::Weight::NORMAL);
+  gfx::FontList font_list(label_font);
+  label->SetFontList(font_list);
+}
+
+}  // namespace
+
+QuickActionItem::QuickActionItem(Delegate* delegate,
+                                 int label_id,
+                                 const gfx::VectorIcon& icon_on,
+                                 const gfx::VectorIcon& icon_off)
+    : delegate_(delegate), icon_on_(icon_on), icon_off_(icon_off) {
+  auto* layout = SetLayoutManager(std::make_unique<views::BoxLayout>(
+      views::BoxLayout::Orientation::kVertical, gfx::Insets(),
+      kUnifiedFeaturePodSpacing));
+  layout->set_cross_axis_alignment(
+      views::BoxLayout::CrossAxisAlignment::kCenter);
+
+  icon_button_ = AddChildView(
+      std::make_unique<FeaturePodIconButton>(this, true /* is_togglable */));
+
+  auto* label_view = AddChildView(std::make_unique<views::View>());
+  label_view->SetLayoutManager(std::make_unique<views::BoxLayout>(
+      views::BoxLayout::Orientation::kVertical, gfx::Insets()));
+
+  label_ = label_view->AddChildView(
+      std::make_unique<views::Label>(l10n_util::GetStringUTF16(label_id)));
+  ConfigureLabel(label_, true /* is_primary */);
+
+  sub_label_ = label_view->AddChildView(std::make_unique<views::Label>());
+  ConfigureLabel(sub_label_, false /* is_primary */);
+
+  SetPaintToLayer();
+  layer()->SetFillsBoundsOpaquely(false);
+}
+
+QuickActionItem::QuickActionItem(Delegate* delegate,
+                                 int label_id,
+                                 const gfx::VectorIcon& icon)
+    : QuickActionItem(delegate, label_id, icon, icon) {}
+
+QuickActionItem::~QuickActionItem() = default;
+
+void QuickActionItem::SetSubLabel(const base::string16& sub_label) {
+  sub_label_->SetText(sub_label);
+}
+
+void QuickActionItem::SetIconTooltip(const base::string16& text) {
+  icon_button_->SetTooltipText(text);
+}
+
+void QuickActionItem::SetToggled(bool toggled) {
+  icon_button_->SetToggled(toggled);
+  icon_button_->SetVectorIcon(toggled ? icon_on_ : icon_off_);
+}
+
+bool QuickActionItem::IsToggled() const {
+  return icon_button_->toggled();
+}
+
+const base::string16& QuickActionItem::GetItemLabel() const {
+  return label_->GetText();
+}
+
+void QuickActionItem::SetEnabled(bool enabled) {
+  View::SetEnabled(enabled);
+  icon_button_->SetEnabled(enabled);
+
+  if (!enabled) {
+    label_->SetEnabledColor(
+        AshColorProvider::GetDisabledColor(label_->GetEnabledColor()));
+    sub_label_->SetEnabledColor(
+        AshColorProvider::GetDisabledColor(sub_label_->GetEnabledColor()));
+
+    sub_label_->SetText(l10n_util::GetStringUTF16(
+        IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_AVAILABLE_STATE));
+    icon_button_->SetTooltipText(l10n_util::GetStringFUTF16(
+        IDS_ASH_PHONE_HUB_QUICK_ACTIONS_NOT_AVAILABLE_STATE_TOOLTIP,
+        GetItemLabel()));
+  } else {
+    ConfigureLabel(label_, true /* is_primary */);
+    ConfigureLabel(sub_label_, false /* is_primary */);
+  }
+}
+
+void QuickActionItem::ButtonPressed(views::Button* sender,
+                                    const ui::Event& event) {
+  delegate_->OnButtonPressed(IsToggled());
+}
+
+bool QuickActionItem::HasFocus() const {
+  return icon_button_->HasFocus() || label_->HasFocus() ||
+         sub_label_->HasFocus();
+}
+
+void QuickActionItem::RequestFocus() {
+  icon_button_->RequestFocus();
+}
+
+const char* QuickActionItem::GetClassName() const {
+  return "QuickActionItem";
+}
+
+}  // namespace ash

ash/system/phonehub/quick_action_item.h

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SYSTEM_PHONEHUB_QUICK_ACTION_ITEM_H_
+#define ASH_SYSTEM_PHONEHUB_QUICK_ACTION_ITEM_H_
+
+#include "ash/ash_export.h"
+#include "ash/system/unified/feature_pod_button.h"
+#include "ui/views/controls/button/button.h"
+
+namespace views {
+class Label;
+}
+
+namespace ash {
+
+// A toggle button with labels used in the quick action view.
+class QuickActionItem : public views::View, public views::ButtonListener {
+ public:
+  class Delegate {
+   public:
+    // Called when the button of the quick action item is clicked.
+    virtual void OnButtonPressed(bool is_now_enabled) = 0;
+  };
+
+  // |icon_on| and |icon_off| indicates the icons used in on/off state of the
+  // button.
+  QuickActionItem(Delegate* delegate,
+                  int label_id,
+                  const gfx::VectorIcon& icon_on,
+                  const gfx::VectorIcon& icon_off);
+
+  // If only one icon is supplied, it will be used in both cases.
+  QuickActionItem(Delegate* delegate,
+                  int label_id,
+                  const gfx::VectorIcon& icon);
+
+  ~QuickActionItem() override;
+  QuickActionItem(QuickActionItem&) = delete;
+  QuickActionItem operator=(QuickActionItem&) = delete;
+
+  // Set the text of sub-label shown below the label.
+  void SetSubLabel(const base::string16& sub_label);
+
+  // Set the tooltip text of the icon button.
+  void SetIconTooltip(const base::string16& text);
+
+  // Change the toggled state. If toggled, the background color of the circle
+  // will change.
+  void SetToggled(bool toggled);
+  bool IsToggled() const;
+
+  // Get the title/label text of the item.
+  const base::string16& GetItemLabel() const;
+
+  // Set the item to be enabled or disabled. When disabled, the button cannot be
+  // clicked and the labels are greyed out.
+  void SetEnabled(bool enabled);
+
+  // views::ButtonListener:
+  void ButtonPressed(views::Button* sender, const ui::Event& event) override;
+
+  // views::View:
+  bool HasFocus() const override;
+  void RequestFocus() override;
+  const char* GetClassName() const override;
+
+  FeaturePodIconButton* icon_button() const { return icon_button_; }
+
+ private:
+  Delegate* delegate_ = nullptr;
+
+  // Owned by views hierarchy.
+  FeaturePodIconButton* icon_button_ = nullptr;
+  const gfx::VectorIcon& icon_on_;
+  const gfx::VectorIcon& icon_off_;
+  views::Label* label_ = nullptr;
+  views::Label* sub_label_ = nullptr;
+};
+
+}  // namespace ash
+
+#endif  // ASH_SYSTEM_PHONEHUB_QUICK_ACTION_VIEW_H_

ash/system/phonehub/quick_actions_view.cc

@@ -4,108 +4,25 @@
 
 #include "ash/system/phonehub/quick_actions_view.h"
 
-#include "ash/resources/vector_icons/vector_icons.h"
-#include "ash/strings/grit/ash_strings.h"
-#include "ash/style/ash_color_provider.h"
 #include "ash/system/phonehub/phone_hub_view_ids.h"
-#include "ash/system/tray/tray_constants.h"
-#include "ash/system/unified/feature_pod_button.h"
-#include "ui/base/l10n/l10n_util.h"
+#include "ash/system/phonehub/quick_action_item.h"
+#include "ash/system/phonehub/silence_phone_quick_action_controller.h"
 #include "ui/views/layout/box_layout.h"
 
 namespace ash {
 
 namespace {
 
-constexpr int kQuickActionsItemSpacing = 36;
-constexpr int kQuickActionsItemLabelSize = 14;
 constexpr gfx::Insets kQuickActionsViewPadding(16, 4);
-
-void ConfigureLabel(views::Label* label, bool is_primary) {
-  label->SetAutoColorReadabilityEnabled(false);
-  label->SetSubpixelRenderingEnabled(false);
-  label->SetCanProcessEventsWithinSubtree(false);
-
-  auto type = is_primary
-                  ? AshColorProvider::ContentLayerType::kTextColorPrimary
-                  : AshColorProvider::ContentLayerType::kTextColorSecondary;
-  label->SetEnabledColor(AshColorProvider::Get()->GetContentLayerColor(type));
-
-  gfx::Font default_font;
-  gfx::Font label_font = default_font.Derive(
-      kQuickActionsItemLabelSize - default_font.GetFontSize(),
-      gfx::Font::NORMAL, gfx::Font::Weight::NORMAL);
-  gfx::FontList font_list(label_font);
-  label->SetFontList(font_list);
-}
+constexpr int kQuickActionsItemSpacing = 36;
 
 }  // namespace
 
-QuickActionsItem::QuickActionsItem(views::ButtonListener* listener,
-                                   const gfx::VectorIcon& vector_icon,
-                                   int label_id)
-    : icon_button_(new FeaturePodIconButton(listener, true /* is_togglable */)),
-      label_(new views::Label),
-      sub_label_(new views::Label) {
+QuickActionsView::QuickActionsView(
+    chromeos::phonehub::PhoneHubManager* phone_hub_manager)
+    : phone_hub_manager_(phone_hub_manager) {
   SetID(PhoneHubViewID::kQuickActionsView);
 
-  auto* layout = SetLayoutManager(std::make_unique<views::BoxLayout>(
-      views::BoxLayout::Orientation::kVertical, gfx::Insets(),
-      kUnifiedFeaturePodSpacing));
-  layout->set_cross_axis_alignment(
-      views::BoxLayout::CrossAxisAlignment::kCenter);
-
-  icon_button_ = AddChildView(std::make_unique<FeaturePodIconButton>(
-      listener, true /* is_togglable */));
-  icon_button_->SetVectorIcon(vector_icon);
-
-  auto* label_view = AddChildView(std::make_unique<views::View>());
-  label_view->SetLayoutManager(std::make_unique<views::BoxLayout>(
-      views::BoxLayout::Orientation::kVertical, gfx::Insets()));
-
-  label_ = label_view->AddChildView(
-      std::make_unique<views::Label>(l10n_util::GetStringUTF16(label_id)));
-  ConfigureLabel(label_, true /* is_primary */);
-
-  sub_label_ = label_view->AddChildView(std::make_unique<views::Label>());
-  ConfigureLabel(sub_label_, false /* is_primary */);
-
-  SetPaintToLayer();
-  layer()->SetFillsBoundsOpaquely(false);
-}
-
-QuickActionsItem::~QuickActionsItem() = default;
-
-void QuickActionsItem::SetSubLabel(const base::string16& sub_label) {
-  sub_label_->SetText(sub_label);
-}
-
-void QuickActionsItem::SetIconTooltip(const base::string16& text) {
-  icon_button_->SetTooltipText(text);
-}
-
-void QuickActionsItem::SetToggled(bool toggled) {
-  icon_button_->SetToggled(toggled);
-}
-
-const base::string16& QuickActionsItem::GetItemLabel() const {
-  return label_->GetText();
-}
-
-bool QuickActionsItem::HasFocus() const {
-  return icon_button_->HasFocus() || label_->HasFocus() ||
-         sub_label_->HasFocus();
-}
-
-void QuickActionsItem::RequestFocus() {
-  icon_button_->RequestFocus();
-}
-
-const char* QuickActionsItem::GetClassName() const {
-  return "QuickActionsItem";
-}
-
-QuickActionsView::QuickActionsView() {
   auto* layout = SetLayoutManager(std::make_unique<views::BoxLayout>(
       views::BoxLayout::Orientation::kHorizontal, kQuickActionsViewPadding,
       kQuickActionsItemSpacing));
@@ -113,52 +30,21 @@ QuickActionsView::QuickActionsView() {
   layout->set_cross_axis_alignment(
       views::BoxLayout::CrossAxisAlignment::kCenter);
 
-  enable_hotspot_ = AddChildView(std::make_unique<QuickActionsItem>(
-      this, kSystemMenuPhoneIcon, IDS_ASH_PHONE_HUB_ENABLE_HOTSPOT_TITLE));
-  silence_phone_ = AddChildView(std::make_unique<QuickActionsItem>(
-      this, kSystemMenuPhoneIcon, IDS_ASH_PHONE_HUB_SILENCE_PHONE_TITLE));
-  locate_phone_ = AddChildView(std::make_unique<QuickActionsItem>(
-      this, kSystemMenuPhoneIcon, IDS_ASH_PHONE_HUB_LOCATE_PHONE_TITLE));
-
-  Update();
+  InitQuickActionItems();
 }
 
 QuickActionsView::~QuickActionsView() = default;
 
-void QuickActionsView::ButtonPressed(views::Button* sender,
-                                     const ui::Event& event) {
-  // TODO(leandre): implement quick actions button functionality.
-  if (sender == enable_hotspot_->icon_button()) {
-    UpdateItem(enable_hotspot_, !enable_hotspot_->IsToggled());
-  } else if (sender == silence_phone_->icon_button()) {
-    UpdateItem(silence_phone_, !silence_phone_->IsToggled());
-  } else if (sender == locate_phone_->icon_button()) {
-    UpdateItem(locate_phone_, !locate_phone_->IsToggled());
-  } else {
-    NOTREACHED();
-  }
-}
-
-void QuickActionsView::Update() {
-  // TODO(leandre): Update items according to phone status.
-  UpdateItem(enable_hotspot_, false);
-  UpdateItem(silence_phone_, true);
-  UpdateItem(locate_phone_, false);
+void QuickActionsView::InitQuickActionItems() {
+  silence_phone_ = AddItem(std::make_unique<SilencePhoneQuickActionController>(
+      phone_hub_manager_->GetDoNotDisturbController()));
 }
 
-void QuickActionsView::UpdateItem(QuickActionsItem* item, bool is_enabled) {
-  item->SetToggled(is_enabled);
-  item->SetSubLabel(l10n_util::GetStringUTF16(
-      is_enabled ? IDS_ASH_PHONE_HUB_QUICK_ACTIONS_ON_STATE
-                 : IDS_ASH_PHONE_HUB_QUICK_ACTIONS_OFF_STATE));
-  int state_text_id =
-      is_enabled ? IDS_ASH_PHONE_HUB_QUICK_ACTIONS_ENABLED_STATE_TOOLTIP
-                 : IDS_ASH_PHONE_HUB_QUICK_ACTIONS_DISABLED_STATE_TOOLTIP;
-  base::string16 tooltip_state =
-      l10n_util::GetStringFUTF16(state_text_id, item->GetItemLabel());
-  item->SetIconTooltip(
-      l10n_util::GetStringFUTF16(IDS_ASH_PHONE_HUB_QUICK_ACTIONS_TOGGLE_TOOLTIP,
-                                 item->GetItemLabel(), tooltip_state));
+QuickActionItem* QuickActionsView::AddItem(
+    std::unique_ptr<QuickActionControllerBase> controller) {
+  auto* item = AddChildView(controller->CreateItem());
+  quick_action_controllers_.push_back(std::move(controller));
+  return item;
 }
 
 }  // namespace ash

ash/system/phonehub/quick_actions_view.h

@@ -6,70 +6,42 @@
 #define ASH_SYSTEM_PHONEHUB_QUICK_ACTIONS_VIEW_H_
 
 #include "ash/ash_export.h"
-#include "ash/system/unified/feature_pod_button.h"
-#include "ui/views/controls/button/button.h"
-#include "ui/views/controls/label.h"
+#include "chromeos/components/phonehub/phone_hub_manager.h"
+#include "ui/views/view.h"
 
 namespace ash {
 
-// A toggle button with labels used in the quick actions view.
-class QuickActionsItem : public views::View {
- public:
-  explicit QuickActionsItem(views::ButtonListener* listener,
-                            const gfx::VectorIcon& vector_icon,
-                            int label_id);
-  ~QuickActionsItem() override;
-  QuickActionsItem(QuickActionsItem&) = delete;
-  QuickActionsItem operator=(QuickActionsItem&) = delete;
-
-  // Set the text of sub-label shown below the label.
-  void SetSubLabel(const base::string16& sub_label);
-
-  // Set the tooltip text of the icon button.
-  void SetIconTooltip(const base::string16& text);
-
-  // Change the toggled state. If toggled, the background color of the circle
-  // will change.
-  void SetToggled(bool toggled);
-  bool IsToggled() const { return icon_button_->toggled(); }
-
-  // Get the title/label text of the item.
-  const base::string16& GetItemLabel() const;
-
-  // views::View:
-  bool HasFocus() const override;
-  void RequestFocus() override;
-  const char* GetClassName() const override;
-
-  FeaturePodIconButton* icon_button() const { return icon_button_; }
-
- private:
-  // Owned by views hierarchy.
-  FeaturePodIconButton* icon_button_ = nullptr;
-  views::Label* label_ = nullptr;
-  views::Label* sub_label_ = nullptr;
-};
+class QuickActionControllerBase;
+class QuickActionItem;
 
 // A view in Phone Hub bubble that contains toggle button for quick actions such
 // as enable hotspot, silence phone and locate phone.
-class ASH_EXPORT QuickActionsView : public views::View,
-                                    public views::ButtonListener {
+class ASH_EXPORT QuickActionsView : public views::View {
  public:
-  QuickActionsView();
+  explicit QuickActionsView(
+      chromeos::phonehub::PhoneHubManager* phone_hub_manager);
   ~QuickActionsView() override;
   QuickActionsView(QuickActionsView&) = delete;
   QuickActionsView operator=(QuickActionsView&) = delete;
 
-  // views::ButtonListener:
-  void ButtonPressed(views::Button* sender, const ui::Event& event) override;
-
  private:
-  void Update();
-  void UpdateItem(QuickActionsItem* item, bool is_enabled);
+  FRIEND_TEST_ALL_PREFIXES(QuickActionsViewTest, QuickActionsToggle);
+
+  // Add all the quick actions items to the view.
+  void InitQuickActionItems();
+
+  // Helper function to add an item to the view given its controller.
+  QuickActionItem* AddItem(
+      std::unique_ptr<QuickActionControllerBase> controller);
+
+  // Controllers of quick actions items. Owned by this.
+  std::vector<std::unique_ptr<QuickActionControllerBase>>
+      quick_action_controllers_;
+
+  chromeos::phonehub::PhoneHubManager* phone_hub_manager_ = nullptr;
 
-  QuickActionsItem* enable_hotspot_ = nullptr;
-  QuickActionsItem* silence_phone_ = nullptr;
-  QuickActionsItem* locate_phone_ = nullptr;
+  // QuickActionItem for unit testing. Owned by this view.
+  QuickActionItem* silence_phone_ = nullptr;
 };
 
 }  // namespace ash

ash/system/phonehub/quick_actions_view_unittest.cc

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/system/phonehub/quick_actions_view.h"
+
+#include "ash/system/phonehub/quick_action_item.h"
+#include "ash/test/ash_test_base.h"
+#include "base/test/scoped_feature_list.h"
+#include "chromeos/components/phonehub/fake_phone_hub_manager.h"
+#include "chromeos/constants/chromeos_features.h"
+
+namespace ash {
+
+using Status = chromeos::phonehub::TetherController::Status;
+
+namespace {
+
+class DummyEvent : public ui::Event {
+ public:
+  DummyEvent() : Event(ui::ET_UNKNOWN, base::TimeTicks(), 0) {}
+};
+
+}  // namespace
+
+class QuickActionsViewTest : public AshTestBase {
+ public:
+  QuickActionsViewTest() = default;
+  ~QuickActionsViewTest() override = default;
+
+  // AshTestBase:
+  void SetUp() override {
+    feature_list_.InitAndEnableFeature(chromeos::features::kPhoneHub);
+    AshTestBase::SetUp();
+
+    quick_actions_view_ =
+        std::make_unique<QuickActionsView>(&phone_hub_manager_);
+  }
+
+  void TearDown() override {
+    quick_actions_view_.reset();
+    AshTestBase::TearDown();
+  }
+
+ protected:
+  QuickActionsView* actions_view() { return quick_actions_view_.get(); }
+  chromeos::phonehub::FakeTetherController* tether_controller() {
+    return phone_hub_manager_.fake_tether_controller();
+  }
+  chromeos::phonehub::FakeDoNotDisturbController* dnd_controller() {
+    return phone_hub_manager_.fake_do_not_disturb_controller();
+  }
+  chromeos::phonehub::FakeFindMyDeviceController* find_my_device_controller() {
+    return phone_hub_manager_.fake_find_my_device_controller();
+  }
+
+ private:
+  std::unique_ptr<QuickActionsView> quick_actions_view_;
+  chromeos::phonehub::FakePhoneHubManager phone_hub_manager_;
+  base::test::ScopedFeatureList feature_list_;
+};
+
+TEST_F(QuickActionsViewTest, QuickActionsToggle) {
+  // Initially, silence phone is not enabled.
+  EXPECT_FALSE(dnd_controller()->IsDndEnabled());
+
+  // Toggle the button will enable the feature.
+  actions_view()->silence_phone_->ButtonPressed(nullptr, DummyEvent());
+  EXPECT_TRUE(dnd_controller()->IsDndEnabled());
+
+  // Togge again to disable.
+  actions_view()->silence_phone_->ButtonPressed(nullptr, DummyEvent());
+  EXPECT_FALSE(dnd_controller()->IsDndEnabled());
+}
+
+}  // namespace ash

ash/system/phonehub/silence_phone_quick_action_controller.cc

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/system/phonehub/silence_phone_quick_action_controller.h"
+
+#include "ash/resources/vector_icons/vector_icons.h"
+#include "ash/strings/grit/ash_strings.h"
+#include "ash/system/phonehub/quick_action_item.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace ash {
+
+SilencePhoneQuickActionController::SilencePhoneQuickActionController(
+    chromeos::phonehub::DoNotDisturbController* dnd_controller)
+    : dnd_controller_(dnd_controller) {
+  DCHECK(dnd_controller_);
+  dnd_controller_->AddObserver(this);
+}
+
+SilencePhoneQuickActionController::~SilencePhoneQuickActionController() {
+  dnd_controller_->RemoveObserver(this);
+}
+
+QuickActionItem* SilencePhoneQuickActionController::CreateItem() {
+  DCHECK(!item_);
+  item_ = new QuickActionItem(this, IDS_ASH_PHONE_HUB_SILENCE_PHONE_TITLE,
+                              kSystemMenuPhoneIcon);
+  OnDndStateChanged();
+  return item_;
+}
+
+void SilencePhoneQuickActionController::OnButtonPressed(bool is_now_enabled) {
+  SetState(ActionState::kConnecting);
+  dnd_controller_->RequestNewDoNotDisturbState(!is_now_enabled);
+  // TODO(leandre): Add a timer to switch back to off state after connecting
+  // failed.
+}
+
+void SilencePhoneQuickActionController::OnDndStateChanged() {
+  dnd_controller_->IsDndEnabled() ? SetState(ActionState::kOn)
+                                  : SetState(ActionState::kOff);
+}
+
+void SilencePhoneQuickActionController::SetState(ActionState state) {
+  bool icon_enabled;
+  int state_text_id;
+  int sub_label_text;
+  switch (state) {
+    case ActionState::kOff:
+      icon_enabled = false;
+      state_text_id = IDS_ASH_PHONE_HUB_QUICK_ACTIONS_DISABLED_STATE_TOOLTIP;
+      sub_label_text = IDS_ASH_PHONE_HUB_QUICK_ACTIONS_OFF_STATE;
+      break;
+    case ActionState::kConnecting:
+      icon_enabled = true;
+      state_text_id = IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTING_STATE_TOOLTIP;
+      sub_label_text = IDS_ASH_PHONE_HUB_QUICK_ACTIONS_CONNECTING_STATE;
+      break;
+    case ActionState::kOn:
+      icon_enabled = true;
+      state_text_id = IDS_ASH_PHONE_HUB_QUICK_ACTIONS_ENABLED_STATE_TOOLTIP;
+      sub_label_text = IDS_ASH_PHONE_HUB_QUICK_ACTIONS_ON_STATE;
+      break;
+  }
+
+  item_->SetToggled(icon_enabled);
+  item_->SetSubLabel(l10n_util::GetStringUTF16(sub_label_text));
+  base::string16 tooltip_state =
+      l10n_util::GetStringFUTF16(state_text_id, item_->GetItemLabel());
+  item_->SetIconTooltip(
+      l10n_util::GetStringFUTF16(IDS_ASH_PHONE_HUB_QUICK_ACTIONS_TOGGLE_TOOLTIP,
+                                 item_->GetItemLabel(), tooltip_state));
+}
+
+}  // namespace ash

ash/system/phonehub/silence_phone_quick_action_controller.h

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SYSTEM_PHONEHUB_SILENCE_PHONE_QUICK_ACTION_CONTROLLER_H_
+#define ASH_SYSTEM_PHONEHUB_SILENCE_PHONE_QUICK_ACTION_CONTROLLER_H_
+
+#include "ash/system/phonehub/quick_action_controller_base.h"
+#include "chromeos/components/phonehub/do_not_disturb_controller.h"
+
+namespace ash {
+
+// Controller of a quick action item that toggles silence phone mode.
+class SilencePhoneQuickActionController
+    : public QuickActionControllerBase,
+      public chromeos::phonehub::DoNotDisturbController::Observer {
+ public:
+  explicit SilencePhoneQuickActionController(
+      chromeos::phonehub::DoNotDisturbController* dnd_controller);
+  ~SilencePhoneQuickActionController() override;
+  SilencePhoneQuickActionController(SilencePhoneQuickActionController&) =
+      delete;
+  SilencePhoneQuickActionController operator=(
+      SilencePhoneQuickActionController&) = delete;
+
+  // QuickActionControllerBase:
+  QuickActionItem* CreateItem() override;
+  void OnButtonPressed(bool is_now_enabled) override;
+
+  // chromeos::phonehub::DoNotDisturbController::Observer:
+  void OnDndStateChanged() override;
+
+ private:
+  // All the possible states that the silence phone button can be viewed. Each
+  // state has a corresponding icon, labels and tooltip view.
+  enum class ActionState { kOff, kConnecting, kOn };
+
+  // Set the item (including icon, label and tooltips) to a certain state.
+  void SetState(ActionState state);
+
+  chromeos::phonehub::DoNotDisturbController* dnd_controller_ = nullptr;
+  QuickActionItem* item_ = nullptr;
+};
+
+}  // namespace ash
+
+#endif  // ASH_SYSTEM_PHONEHUB_SILENCE_PHONE_QUICK_ACTION_CONTROLLER_H_