Commit bcb2dfd3 authored by Achuith Bhandarkar's avatar Achuith Bhandarkar Committed by Commit Bot

cros-chrome test fixes.

Remote Chrome OS fails on these tests.
* Disable testTelemetryUsesChromeClockDomain.
* Fix testVariationArgs.

BUG=chromium:895977

Change-Id: I62c852017033b57d942c5e7eb07b9cdc8a526e8b
Reviewed-on: https://chromium-review.googlesource.com/c/1284756Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600838}
parent 92f924a5
...@@ -62,7 +62,8 @@ class PerfBenchmarkTest(unittest.TestCase): ...@@ -62,7 +62,8 @@ class PerfBenchmarkTest(unittest.TestCase):
benchmark = perf_benchmark.PerfBenchmark() benchmark = perf_benchmark.PerfBenchmark()
options = options_for_unittests.GetCopy() options = options_for_unittests.GetCopy()
options.chrome_root = self._output_dir options.chrome_root = self._output_dir
options.browser_type = "any" if not options.browser_type:
options.browser_type = "any"
possible_browser = browser_finder.FindBrowser(options) possible_browser = browser_finder.FindBrowser(options)
if possible_browser is None: if possible_browser is None:
return return
......
...@@ -13,10 +13,10 @@ def GetSyncEvents(trace_part): ...@@ -13,10 +13,10 @@ def GetSyncEvents(trace_part):
class ClockDomainTest(tab_test_case.TabTestCase): class ClockDomainTest(tab_test_case.TabTestCase):
# Don't run this test on Android; it's not supposed to work on Android # Don't run this test on Android and remote Chrome OS; it won't work
# (since when doing Android tracing there are two different devices, # because there are two different devices, so the clock domains will
# so the clock domains will be different) # be different.
@decorators.Disabled('android') @decorators.Disabled('android', 'cros-chrome')
@decorators.Isolated @decorators.Isolated
def testTelemetryUsesChromeClockDomain(self): def testTelemetryUsesChromeClockDomain(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment