Commit bce04023 authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot

[COOP] reporting: reenable OriginTrial tests.

Reenable two test:
-CoopReportingOriginTrialBrowserTest.AccessReportingWithToken
-CoopReportingOriginTrialBrowserTest.CoopStateWithToken

They were disabled by:
https://chromium-review.googlesource.com/c/chromium/src/+/2365362

We think this might be fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/2366778

Feel free to immediately revert this patch if the two tests start to
fail. We will also monitor them today.

Bug: 1119555
Change-Id: Ibd6fc4af82fcc4cbd3dcf5fe2b1472d81cb9c8cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366894Reviewed-by: default avatarCamille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800081}
parent 468f3b29
...@@ -1908,8 +1908,19 @@ class CoopReportingOriginTrialBrowserTest : public ContentBrowserTest { ...@@ -1908,8 +1908,19 @@ class CoopReportingOriginTrialBrowserTest : public ContentBrowserTest {
// Origin Trials key generated with: // Origin Trials key generated with:
// //
// tools/origin_trials/generate_token.py --expire-days 5000 --version 3 // tools/origin_trials/generate_token.py https://coop.security:9999
// https://coop.security:9999 CrossOriginOpenerPolicyReporting // CrossOriginOpenerPolicyReporting --version=3 --expire-timestamp=2029708007
//
// Token details:
// Version: 3
// Origin: https://coop.security:9999
// Is Subdomain: None
// Is Third Party: None
// Usage Restriction: None
// Feature: CrossOriginOpenerPolicyReporting
// Expiry: 2029708007 (2034-04-26 23:46:47 UTC)
// Signature (Base64): lTh1cb2ViGEtK6YOZc05uu3nEnRdWlJ/D/Dur4xjM7OI2cd9yXVlK
// GMqN5zIRzcTm8O0dX7CIsxuq6QvCGzyAg==
static std::string OriginTrialToken() { static std::string OriginTrialToken() {
return "A5U4dXG9lYhhLSumDmXNObrt5xJ0XVpSfw/" return "A5U4dXG9lYhhLSumDmXNObrt5xJ0XVpSfw/"
"w7q+MYzOziNnHfcl1ZShjKjecyEc3E5vDtHV+" "w7q+MYzOziNnHfcl1ZShjKjecyEc3E5vDtHV+"
...@@ -1951,6 +1962,13 @@ class CoopReportingOriginTrialBrowserTest : public ContentBrowserTest { ...@@ -1951,6 +1962,13 @@ class CoopReportingOriginTrialBrowserTest : public ContentBrowserTest {
void SetUpCommandLine(base::CommandLine* command_line) final { void SetUpCommandLine(base::CommandLine* command_line) final {
ContentBrowserTest::SetUpCommandLine(command_line); ContentBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kIgnoreCertificateErrors); command_line->AppendSwitch(switches::kIgnoreCertificateErrors);
// TODO(https://crbug.com/1119555): Remove this once fixed.
// This test relies on the origin-trial's public key to continue to be set
// to the default test value. Overriding it would break the test.
CHECK(!command_line->HasSwitch("origin-trial-public-key") ||
command_line->GetSwitchValueASCII("origin-trial-public-key") ==
"dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=");
} }
private: private:
...@@ -1988,9 +2006,8 @@ IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest, ...@@ -1988,9 +2006,8 @@ IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest,
network::mojom::CrossOriginOpenerPolicyValue::kUnsafeNone); network::mojom::CrossOriginOpenerPolicyValue::kUnsafeNone);
} }
// TODO(http://crbug.com/1119555): Flaky on android-bfcache-rel.
IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest, IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest,
DISABLED_CoopStateWithToken) { CoopStateWithToken) {
URLLoaderInterceptor interceptor(base::BindLambdaForTesting( URLLoaderInterceptor interceptor(base::BindLambdaForTesting(
[&](URLLoaderInterceptor::RequestParams* params) { [&](URLLoaderInterceptor::RequestParams* params) {
if (params->url_request.url != OriginTrialURL()) if (params->url_request.url != OriginTrialURL())
...@@ -2018,9 +2035,8 @@ IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest, ...@@ -2018,9 +2035,8 @@ IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest,
network::mojom::CrossOriginOpenerPolicyValue::kSameOriginPlusCoep); network::mojom::CrossOriginOpenerPolicyValue::kSameOriginPlusCoep);
} }
// TODO(http://crbug.com/1119555): Flaky on android-bfcache-rel.
IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest, IN_PROC_BROWSER_TEST_F(CoopReportingOriginTrialBrowserTest,
DISABLED_AccessReportingWithoutToken) { AccessReportingWithoutToken) {
URLLoaderInterceptor interceptor(base::BindLambdaForTesting( URLLoaderInterceptor interceptor(base::BindLambdaForTesting(
[&](URLLoaderInterceptor::RequestParams* params) { [&](URLLoaderInterceptor::RequestParams* params) {
if (params->url_request.url != OriginTrialURL()) if (params->url_request.url != OriginTrialURL())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment