Commit bce93d49 authored by Daniel Rubery's avatar Daniel Rubery Committed by Commit Bot

Re-enable ClientSideDetectionServiceTests

These tests were disabled due to MSan failures, but have been fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/2253759

Fixed: 1096972

Change-Id: I49d5da2660c78a55b7b5590e7b6f775c4bf65a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264018Reviewed-by: default avatarXinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782030}
parent 50b57376
......@@ -337,8 +337,7 @@ TEST_F(ClientSideDetectionServiceTest, IsPrivateIPAddress) {
EXPECT_TRUE(csd_service_->IsPrivateIPAddress("blah"));
}
// Failing test (crbug.com/1096972)
TEST_F(ClientSideDetectionServiceTest, DISABLED_SetEnabledAndRefreshState) {
TEST_F(ClientSideDetectionServiceTest, SetEnabledAndRefreshState) {
// Check that the model isn't downloaded until the service is enabled.
profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
csd_service_ = std::make_unique<ClientSideDetectionService>(profile_);
......@@ -384,8 +383,7 @@ TEST_F(ClientSideDetectionServiceTest, DISABLED_SetEnabledAndRefreshState) {
base::RunLoop().RunUntilIdle();
}
// Failing test (crbug.com/1096972)
TEST_F(ClientSideDetectionServiceTest, DISABLED_TestModelFollowsPrefs) {
TEST_F(ClientSideDetectionServiceTest, TestModelFollowsPrefs) {
profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingScoutReportingEnabled,
false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment