Commit bd10e4c2 authored by Greg Thompson's avatar Greg Thompson Committed by Commit Bot

Restore sizes coverage on Windows.

This change restores sizes coverage of mini_installer.exe, setup.exe,
chrome_proxy.exe, elevation_service.exe, and
notification_helper.exe. Coverage was lost during the migration to
//tools/binary_size/sizes.py. It is restored by adding a missing
data_dep on the Windows installer and adding some missing files to the
sizes script.

Bug: 930325,961548
Change-Id: I3b30afdd7b8f7c40016dc7c6409a473bac817fc1
CC: jbudorick@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807236
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697588}
parent 2c2c3a72
......@@ -2664,6 +2664,9 @@ if (is_linux || is_mac || is_win) {
data_deps = [
"//chrome",
]
if (is_win) {
data_deps += [ "//chrome/installer/mini_installer" ]
}
}
}
......
......@@ -337,10 +337,13 @@ def main_win(output_directory, results_collector, size_path):
'chrome_child.dll',
'chrome_child.dll.pdb',
'chrome_elf.dll',
'chrome_proxy.exe',
'chrome_watcher.dll',
'elevation_service.exe',
'libEGL.dll',
'libGLESv2.dll',
'mini_installer.exe',
'notification_helper.exe',
'resources.pak',
'setup.exe',
'swiftshader\\libEGL.dll',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment