Commit bd137b16 authored by Finnur Thorarinsson's avatar Finnur Thorarinsson Committed by Commit Bot

Win Native Notifications: Log HRESULTs on failed showing of notification.

Bug: 860654, 734095
Change-Id: I4a705377166d9579f27206f92371c02445f2d6bf
Reviewed-on: https://chromium-review.googlesource.com/1185081Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585251}
parent 4a9b0019
......@@ -15,6 +15,7 @@
#include "base/feature_list.h"
#include "base/hash.h"
#include "base/logging.h"
#include "base/metrics/histogram_functions.h"
#include "base/sequenced_task_runner.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
......@@ -701,7 +702,10 @@ class NotificationPlatformBridgeWinImpl
HRESULT error_code;
HRESULT hr = arguments->get_ErrorCode(&error_code);
if (SUCCEEDED(hr)) {
// Error code successfully obtained from the Action Center.
LogOnFailedStatus(OnFailedStatus::SUCCESS);
base::UmaHistogramSparse("Notifications.Windows.DisplayFailure",
error_code);
DLOG(ERROR) << "Failed to raise the toast notification, error code: "
<< std::hex << error_code;
} else {
......
......@@ -63473,6 +63473,15 @@ uploading your change for review.
</summary>
</histogram>
<histogram name="Notifications.Windows.DisplayFailure" enum="Hresult">
<owner>finnur@chromium.org</owner>
<owner>peter@chromium.org</owner>
<summary>
The HRESULT returned by the Windows Action Center, when showing a
notification fails.
</summary>
</histogram>
<histogram name="Notifications.Windows.DisplayStatus"
enum="WindowsNotificationDisplayStatus">
<owner>finnur@chromium.org</owner>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment