Commit bd278588 authored by Theresa Wellington's avatar Theresa Wellington Committed by Commit Bot

[Home] Start closing the bottom sheet before clearing URL focus

Start closing the bottom sheet before clearing URL focus on backpress to
prevent "Search or type URL" from temporarily showing while the bottom
sheet is closing.

BUG=789775

Change-Id: I79bc1013b5dc91cc4ff94a8df86a7df7996b2d69
Reviewed-on: https://chromium-review.googlesource.com/807345Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521572}
parent 2743a763
...@@ -390,11 +390,11 @@ public class LocationBarPhone extends LocationBarLayout { ...@@ -390,11 +390,11 @@ public class LocationBarPhone extends LocationBarLayout {
@Override @Override
public void backKeyPressed() { public void backKeyPressed() {
super.backKeyPressed();
if (mCloseSheetOnBackButton) { if (mCloseSheetOnBackButton) {
mBottomSheet.setSheetState(BottomSheet.SHEET_STATE_PEEK, true); mBottomSheet.setSheetState(BottomSheet.SHEET_STATE_PEEK, true);
} }
mCloseSheetOnBackButton = false; mCloseSheetOnBackButton = false;
super.backKeyPressed();
} }
} }
...@@ -108,7 +108,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool ...@@ -108,7 +108,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool
@Override @Override
public String getText() { public String getText() {
if (isBottomSheetOpen()) return ""; if (clearUrlForBottomSheetOpen()) return "";
String displayText = super.getText(); String displayText = super.getText();
...@@ -199,7 +199,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool ...@@ -199,7 +199,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool
@Override @Override
public boolean shouldShowSecurityIcon() { public boolean shouldShowSecurityIcon() {
return !isBottomSheetOpen() && getSecurityIconResource() != 0; return !clearUrlForBottomSheetOpen() && getSecurityIconResource() != 0;
} }
@Override @Override
...@@ -207,7 +207,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool ...@@ -207,7 +207,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool
// Because is offline page is cleared a bit slower, we also ensure that connection security // Because is offline page is cleared a bit slower, we also ensure that connection security
// level is NONE or HTTP_SHOW_WARNING (http://crbug.com/671453). // level is NONE or HTTP_SHOW_WARNING (http://crbug.com/671453).
int securityLevel = getSecurityLevel(); int securityLevel = getSecurityLevel();
return !isBottomSheetOpen() && isOfflinePage() return !clearUrlForBottomSheetOpen() && isOfflinePage()
&& (securityLevel == ConnectionSecurityLevel.NONE && (securityLevel == ConnectionSecurityLevel.NONE
|| securityLevel == ConnectionSecurityLevel.HTTP_SHOW_WARNING); || securityLevel == ConnectionSecurityLevel.HTTP_SHOW_WARNING);
} }
...@@ -257,8 +257,9 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool ...@@ -257,8 +257,9 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool
return 0; return 0;
} }
private boolean isBottomSheetOpen() { private boolean clearUrlForBottomSheetOpen() {
return mBottomSheet != null && mBottomSheet.isSheetOpen() return mBottomSheet != null && mBottomSheet.isSheetOpen()
&& mBottomSheet.getTargetSheetState() != BottomSheet.SHEET_STATE_PEEK
&& ChromeFeatureList.isEnabled(ChromeFeatureList.CHROME_HOME_CLEAR_URL_ON_OPEN); && ChromeFeatureList.isEnabled(ChromeFeatureList.CHROME_HOME_CLEAR_URL_ON_OPEN);
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment