Commit bd3f4442 authored by Katie Dillon's avatar Katie Dillon Committed by Commit Bot

[scheduling] Don't pass a queue to record task time on budget pools for find...

[scheduling] Don't pass a queue to record task time on budget pools for find in page and compositor experiments.

The cpu time budget pool doesn't use the queue that it is passed when it
records task run time, so we will pass nullptr in those spots instead.
This will allow us to avoid passing a raw pointer to a TaskQueue in a spot
we don't need it as a pre-requisite to this CL: crrev.com/c/2453591.

Change-Id: Ifc7de7e94e667c1de1d4bc4de30203becc03fafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485346Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819141}
parent 507ab598
......@@ -213,8 +213,8 @@ void CompositorPriorityExperiments::CompositorBudgetPoolController::
MainThreadTaskQueue::TaskTiming* task_timing,
bool have_seen_stop_signal) {
if (have_seen_stop_signal) {
compositor_budget_pool_->RecordTaskRunTime(queue, task_timing->start_time(),
task_timing->end_time());
compositor_budget_pool_->RecordTaskRunTime(
nullptr, task_timing->start_time(), task_timing->end_time());
}
UpdateCompositorBudgetState(task_timing->end_time());
}
......
......@@ -59,7 +59,7 @@ void FindInPageBudgetPoolController::OnTaskCompleted(
if (queue->GetPrioritisationType() ==
MainThreadTaskQueue::QueueTraits::PrioritisationType::kFindInPage) {
find_in_page_budget_pool_->RecordTaskRunTime(
queue, task_timing->start_time(), task_timing->end_time());
nullptr, task_timing->start_time(), task_timing->end_time());
}
bool is_exhausted = !find_in_page_budget_pool_->CanRunTasksAt(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment