Commit bd435986 authored by Dave Tapuska's avatar Dave Tapuska Committed by Chromium LUCI CQ

Remove Blink.ResourceFetcher.StaleWhileRevalidateDuration metric.

The metric has been expired. Remove dead code.

BUG=1055384

Change-Id: Ic5df4f8f54adc8057993ab70e66403125e4a5914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587433Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836835}
parent 30c287a1
...@@ -11,7 +11,7 @@ namespace blink { ...@@ -11,7 +11,7 @@ namespace blink {
StaleRevalidationResourceClient::StaleRevalidationResourceClient( StaleRevalidationResourceClient::StaleRevalidationResourceClient(
Resource* stale_resource) Resource* stale_resource)
: start_time_(base::TimeTicks::Now()), stale_resource_(stale_resource) {} : stale_resource_(stale_resource) {}
StaleRevalidationResourceClient::~StaleRevalidationResourceClient() = default; StaleRevalidationResourceClient::~StaleRevalidationResourceClient() = default;
...@@ -20,13 +20,6 @@ void StaleRevalidationResourceClient::NotifyFinished(Resource* resource) { ...@@ -20,13 +20,6 @@ void StaleRevalidationResourceClient::NotifyFinished(Resource* resource) {
if (stale_resource_ && IsMainThread()) if (stale_resource_ && IsMainThread())
GetMemoryCache()->Remove(stale_resource_); GetMemoryCache()->Remove(stale_resource_);
ClearResource(); ClearResource();
base::TimeTicks response_end = resource->LoadResponseEnd();
if (!response_end.is_null()) {
UMA_HISTOGRAM_LONG_TIMES(
"Blink.ResourceFetcher.StaleWhileRevalidateDuration",
response_end - start_time_);
}
} }
void StaleRevalidationResourceClient::Trace(Visitor* visitor) const { void StaleRevalidationResourceClient::Trace(Visitor* visitor) const {
......
...@@ -26,7 +26,6 @@ class StaleRevalidationResourceClient ...@@ -26,7 +26,6 @@ class StaleRevalidationResourceClient
String DebugName() const override; String DebugName() const override;
private: private:
base::TimeTicks start_time_;
// |stale_resource_| is the original resource that will be removed from the // |stale_resource_| is the original resource that will be removed from the
// MemoryCache when this revalidation request is completed. Note that it is // MemoryCache when this revalidation request is completed. Note that it is
// different than the active resource for this resource client which accessed // different than the active resource for this resource client which accessed
......
...@@ -1740,6 +1740,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1740,6 +1740,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Blink.ResourceFetcher.StaleWhileRevalidateDuration" units="ms" <histogram name="Blink.ResourceFetcher.StaleWhileRevalidateDuration" units="ms"
expires_after="2020-04-05"> expires_after="2020-04-05">
<obsolete>
Removed 12/2020.
</obsolete>
<owner>dtapuska@chromium.org</owner> <owner>dtapuska@chromium.org</owner>
<owner>kenjibaheux@google.com</owner> <owner>kenjibaheux@google.com</owner>
<summary>Duration of completed stale revalidation attempts.</summary> <summary>Duration of completed stale revalidation attempts.</summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment