Commit bd5e3cd2 authored by brettw@chromium.org's avatar brettw@chromium.org

GN Windows build fixes

Reland of https://codereview.chromium.org/404603002/ but without the problematic extensions.gypi changes.

R=agl@chromium.org, dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/400233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284703 0039d316-1c4b-4281-b951-d872f2087c98
parent 51a7aec7
...@@ -56,7 +56,6 @@ component("ash") { ...@@ -56,7 +56,6 @@ component("ash") {
if (is_win) { if (is_win) {
sources -= [ sources -= [
"host/window_tree_host_factory.cc",
"sticky_keys/sticky_keys_controller.cc", "sticky_keys/sticky_keys_controller.cc",
"sticky_keys/sticky_keys_controller.h", "sticky_keys/sticky_keys_controller.h",
] ]
...@@ -76,8 +75,6 @@ component("ash") { ...@@ -76,8 +75,6 @@ component("ash") {
"accelerators/magnifier_key_scroller.h", "accelerators/magnifier_key_scroller.h",
"accelerators/spoken_feedback_toggler.cc", "accelerators/spoken_feedback_toggler.cc",
"accelerators/spoken_feedback_toggler.h", "accelerators/spoken_feedback_toggler.h",
"touch/touch_transformer_controller.cc",
"touch/touch_transformer_controller.h",
] ]
} }
...@@ -102,6 +99,11 @@ component("ash") { ...@@ -102,6 +99,11 @@ component("ash") {
"system/tray/media_security/media_capture_observer.h", "system/tray/media_security/media_capture_observer.h",
"system/tray/media_security/multi_profile_media_tray_item.cc", "system/tray/media_security/multi_profile_media_tray_item.cc",
"system/tray/media_security/multi_profile_media_tray_item.h", "system/tray/media_security/multi_profile_media_tray_item.h",
]
}
if (!use_x11 || !is_chromeos) {
sources -= [
"touch/touch_transformer_controller.cc", "touch/touch_transformer_controller.cc",
"touch/touch_transformer_controller.h", "touch/touch_transformer_controller.h",
] ]
......
...@@ -918,7 +918,6 @@ ...@@ -918,7 +918,6 @@
['OS=="win"', { ['OS=="win"', {
'sources!': [ 'sources!': [
# Note: sources list duplicated in GN build. # Note: sources list duplicated in GN build.
"host/window_tree_host_factory.cc",
"sticky_keys/sticky_keys_controller.cc", "sticky_keys/sticky_keys_controller.cc",
"sticky_keys/sticky_keys_controller.h", "sticky_keys/sticky_keys_controller.h",
], ],
......
...@@ -66,7 +66,8 @@ static_library("storage_monitor") { ...@@ -66,7 +66,8 @@ static_library("storage_monitor") {
deps += [ deps += [
"//device/udev_linux", "//device/udev_linux",
] ]
} else { } else if (is_linux) {
# These were already removed for non-Linux.
sources -= [ sources -= [
"storage_monitor_linux.cc", "storage_monitor_linux.cc",
"storage_monitor_linux.h", "storage_monitor_linux.h",
......
...@@ -68,7 +68,6 @@ component("ipc") { ...@@ -68,7 +68,6 @@ component("ipc") {
if (is_win || is_ios) { if (is_win || is_ios) {
sources -= [ sources -= [
"unix_domain_socket_acceptor.cc",
"unix_domain_socket_util.cc", "unix_domain_socket_util.cc",
] ]
} }
......
...@@ -32,9 +32,9 @@ config("media_config") { ...@@ -32,9 +32,9 @@ config("media_config") {
} }
} }
if (is_win) { config("media_dependent_config") {
config("media_dependent_config") { if (is_win) {
ldflags += [ ldflags = [
"/DELAYLOAD:mf.dll", "/DELAYLOAD:mf.dll",
"/DELAYLOAD:mfplat.dll", "/DELAYLOAD:mfplat.dll",
"/DELAYLOAD:mfreadwrite.dll", "/DELAYLOAD:mfreadwrite.dll",
...@@ -354,7 +354,9 @@ component("media") { ...@@ -354,7 +354,9 @@ component("media") {
] ]
configs += [ ":media_config", ] configs += [ ":media_config", ]
all_dependent_configs = [ ":media_dependent_config" ]
cflags = []
libs = [] libs = []
defines = [] defines = []
deps = [] deps = []
...@@ -555,8 +557,6 @@ component("media") { ...@@ -555,8 +557,6 @@ component("media") {
"/wd4267" # TODO(wolenetz): Fix size_t to int trunctaion in win64. See "/wd4267" # TODO(wolenetz): Fix size_t to int trunctaion in win64. See
# http://crbug.com/171009 # http://crbug.com/171009
] ]
configs += [ ":media_dependent_config" ]
all_dependent_configs = [ ":media_dependent_config" ]
} }
if (proprietary_codecs) { if (proprietary_codecs) {
......
...@@ -58,13 +58,18 @@ component("views") { ...@@ -58,13 +58,18 @@ component("views") {
sources -= [ sources -= [
"linux_ui/linux_ui.h", "linux_ui/linux_ui.h",
"linux_ui/linux_ui.cc", "linux_ui/linux_ui.cc",
"linux_ui/status_icon_linux.h",
"linux_ui/status_icon_linux.cc",
"linux_ui/window_button_order_observer.h", "linux_ui/window_button_order_observer.h",
"linux_ui/window_button_order_provider.cc", "linux_ui/window_button_order_provider.cc",
] ]
} }
if (is_chromeos) {
sources -= [
"linux_ui/status_icon_linux.h",
"linux_ui/status_icon_linux.cc",
]
}
if (is_win) { if (is_win) {
sources += gypi_values.views_win_sources sources += gypi_values.views_win_sources
cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment