Commit bd727367 authored by groby@chromium.org's avatar groby@chromium.org

[WebIntents] Cleanup of unused functions/default implementations


R=jhawkins@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10855137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151638 0039d316-1c4b-4281-b951-d872f2087c98
parent ebfb73cb
......@@ -17,6 +17,11 @@ class WebIntentPickerMock : public WebIntentPicker {
public:
virtual void Close() OVERRIDE {}
virtual void SetActionString(const string16& action) OVERRIDE {}
virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE {}
virtual void OnExtensionInstallFailure(const std::string& id) OVERRIDE {}
virtual void OnInlineDispositionAutoResize(const gfx::Size& size) OVERRIDE {}
virtual void OnPendingAsyncCompleted() OVERRIDE {}
};
class WebIntentInlineDispositionBrowserTest
......
......@@ -37,26 +37,22 @@ class WebIntentPicker {
virtual void SetActionString(const string16& action) = 0;
// Called when an extension is successfully installed via the picker.
virtual void OnExtensionInstallSuccess(const std::string& id) {}
virtual void OnExtensionInstallSuccess(const std::string& id) = 0;
// Called when an extension installation started via the picker has failed.
virtual void OnExtensionInstallFailure(const std::string& id) {}
virtual void OnExtensionInstallFailure(const std::string& id) = 0;
// Called when the inline disposition experiences an auto-resize.
virtual void OnInlineDispositionAutoResize(const gfx::Size& size) {}
virtual void OnInlineDispositionAutoResize(const gfx::Size& size) = 0;
// Called when the controller has finished all pending asynchronous
// activities.
virtual void OnPendingAsyncCompleted() {}
virtual void OnPendingAsyncCompleted() = 0;
// Called when the inline disposition's web contents have been loaded.
virtual void OnInlineDispositionWebContentsLoaded(
content::WebContents* web_contents) {}
// Get the default size of the inline disposition tab container.
static gfx::Size GetDefaultInlineDispositionSize(
content::WebContents* web_contents);
// Get the minimum size of the inline disposition content container.
static gfx::Size GetMinInlineDispositionSize();
......
......@@ -118,6 +118,7 @@ class WebIntentPickerMock : public WebIntentPicker,
num_extensions_installed_++;
}
virtual void OnExtensionInstallFailure(const std::string& id) OVERRIDE {}
virtual void OnInlineDispositionAutoResize(const gfx::Size& size) OVERRIDE {}
virtual void OnPendingAsyncCompleted() OVERRIDE {
StopWaiting();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment