Roll src/net/third_party/quiche/src/ 60e12c402..5a4f76123 (23 commits)

https://quiche.googlesource.com/quiche.git/+log/60e12c40278b..5a4f76123806

$ git log 60e12c402..5a4f76123 --date=short --no-merges --format='%ad %ae %s'
2020-10-09 zhongyi use size_t* instead of QuicByteCount* to fix quiche roll.
2020-10-09 mattm QUIC Key Update support
2020-10-09 vasilvv Replace quiche::QuicheStringPiece with absl::string_view.
2020-10-09 renjietang Temporarily disable EndToEndTest.MultipleZeroRtt in Chrome.
2020-10-09 mattm Rename CryptoUtils::SetKeyAndIV to InitializeCrypterSecrets and add separate SetKeyAndIV and GenerateHeaderProtectionKey methods.
2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-09 wub For BBRv2, - Change the default STARTUP and DRAIN cwnd gain to 2.0. - Change the meaning of BBQ2 to use 2.885 cwnd gain for STARTUP and DRAIN.
2020-10-08 mattm Move StrictTaggingDecrypter to quic_test_utils.h
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 bnc Use faster Huffman encoding for QPACK.
2020-10-08 bnc Eliminate copying of Huffman encoded string in QpackInstructionEncoder.
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-08 bnc Append to output instead of overwriting it in http2::HuffmanEncode().
2020-10-07 vasilvv Replace QuicheStringPiece with absl::string_view
2020-10-07 dschinazi Fix NetSLO QUIC prober tests
2020-10-07 renjietang Add explicit numbers to QuicStreamRstErrorCode.
2020-10-07 renjietang Add regression test for 0-RTT rejection bug.
2020-10-07 bnc Use faster Huffman encoding for HPACK.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I6679f94041b1202821ad5c622b7a1092412f8349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464182
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816363}

DEPS

@@ -322,7 +322,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling feed
   # and whatever else without interference from each other.
-  'quiche_revision': '60e12c40278b99251d2fa07a0d61a462bf811bd4',
+  'quiche_revision': '5a4f761238065c30c92e90e2f0be13edf54f564f',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling ios_webkit
   # and whatever else without interference from each other.

net/quic/quic_flags_list.h

@@ -228,7 +228,7 @@ QUIC_FLAG(bool,
 QUIC_FLAG(bool, FLAGS_quic_enable_http3_grease_randomness, true)
 
 // If true, disable QUIC version h3-27.
-QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_draft_27, false)
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_draft_27, true)
 
 // If true, server push will be allowed in QUIC versions using HTTP/3.
 QUIC_FLAG(bool, FLAGS_quic_enable_http3_server_push, false)
@@ -282,12 +282,6 @@ QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_disable_server_blackhole_detection,
           false)
 
-// When true, QUIC+TLS versions will send the key_update_not_yet_supported
-// transport parameter.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_send_key_update_not_yet_supported,
-          true)
-
 // If true, QUIC will default enable MTU discovery, with a target of 1450 bytes.
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_enable_mtu_discovery_at_server,
@@ -338,7 +332,7 @@ QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_copy_bbr_cwnd_to_bbr2, true)
 // GOAWAY frame.
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_fix_http3_goaway_stream_id,
-          false)
+          true)
 
 // If true, close connection if writer is still blocked when OnCanWrite is
 // called.
@@ -387,7 +381,7 @@ QUIC_FLAG(
 // If true, abort async QPACK header decompression in QuicSpdyStream::OnClose().
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_abort_qpack_on_stream_close,
-          false)
+          true)
 
 // If true, do not arm PTO for application data until handshake confirmed.
 QUIC_FLAG(bool,
@@ -413,7 +407,7 @@ QUIC_FLAG(bool,
 QUIC_FLAG(
     bool,
     FLAGS_quic_reloadable_flag_quic_bbr2_use_post_inflight_to_detect_queuing,
-    false)
+    true)
 
 // If true, QUIC BBRv2 will use 15% inflight_hi headroom, which is the default
 // for TCP.
@@ -436,7 +430,7 @@ QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_default_to_2_rttvar, true)
 // sent.
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_deallocate_message_right_after_sent,
-          false)
+          true)
 
 // If true, drop initial keys at the end of writing and unify the fixes for
 // missing initial keys.
@@ -468,3 +462,15 @@ QUIC_FLAG(bool,
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_let_connection_handle_pings,
           true)
+
+// If true, BBRv2 will 1) change the default STARTUP and DRAIN cwnd gain to 2.0,
+// and 2) change the meaning of connection option BBQ2 to use 2.885 for STARTUP
+// and DRAIN cwnd gain.
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr2_flip_bbq2, true)
+
+// If true, use http2::HuffmanEncodeFast() instead of HuffmanEncode() and
+// eliminate one string copy for QPACK encoding used in IETF QUIC.
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_use_fast_huffman_encoder, false)
+
+// When true, QUIC+TLS versions will support key updates.
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_key_update_supported, false)

net/quic/quic_test_packet_printer.cc

@@ -164,6 +164,19 @@ class QuicPacketPrinter : public QuicFramerVisitorInterface {
     *output_ << "OnStreamsBlockedFrame: " << frame;
     return true;
   }
+  void OnKeyUpdate() override { *output_ << "OnKeyUpdate\n"; }
+  void OnDecryptedFirstPacketInKeyPhase() override {
+    *output_ << "OnDecryptedFirstPacketInKeyPhase\n";
+  }
+  std::unique_ptr<QuicDecrypter> AdvanceKeysAndCreateCurrentOneRttDecrypter()
+      override {
+    *output_ << "AdvanceKeysAndCreateCurrentOneRttDecrypter\n";
+    return nullptr;
+  }
+  std::unique_ptr<QuicEncrypter> CreateCurrentOneRttEncrypter() override {
+    *output_ << "CreateCurrentOneRttEncrypter\n";
+    return nullptr;
+  }
   bool OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame) override {
     *output_ << "OnWindowUpdateFrame: " << frame;
     return true;

net/spdy/platform/impl/spdy_flags_impl.cc

@@ -4,8 +4,10 @@
 
 #include "net/spdy/platform/impl/spdy_flags_impl.h"
 
-// If true, use indexed name if possible when sending
-// Literal Header Field without Indexing instruction.
-bool spdy_hpack_use_indexed_name = true;
+// If true, use http2::HuffmanSize() instead of
+// spdy::HpackHuffmanTable::EncodedSize() and http2::HuffmanEncodeFast()
+// instead of spdy::HpackHuffmanTable::EncodeString() for HPACK encoding used
+// in HTTP/2 and Google QUIC (not IETF QUIC).
+bool http2_use_fast_huffman_encoder = true;
 
 namespace spdy {}  // namespace spdy

net/spdy/platform/impl/spdy_flags_impl.h

@@ -7,7 +7,7 @@
 
 #include "net/base/net_export.h"
 
-NET_EXPORT_PRIVATE extern bool spdy_hpack_use_indexed_name;
+NET_EXPORT_PRIVATE extern bool http2_use_fast_huffman_encoder;
 
 inline bool GetSpdyReloadableFlagImpl(bool flag) {
   return flag;