Fix MobileSessionAppWillTerminateWasReceived metric in xml

MobileSessionAppWillTerminateWasReceived is how metric actually recorded.
XML had MobileSessionAppWillTerminateReceived ("was" word was missing) and
MobileSessionAppWillTerminateReceived was never recorded.

This CL also renames MobileSessionAppWillTerminateReceived to
MobileSessionAppWillTerminateWasReceived.

Bug: None
Change-Id: I0c1104f9776c696722fd9477097b0630cf13d2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617136Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842236}

ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider.mm

@@ -61,10 +61,10 @@ enum class MobileSessionOomShutdownHint {
   kMaxValue = SessionRestorationXte
 };
 
-// Values of the Stability.iOS.UTE.MobileSessionAppWillTerminateReceived
+// Values of the Stability.iOS.UTE.MobileSessionAppWillTerminateWasReceived
 // histogram. These values are persisted to logs. Entries should not be
 // renumbered and numeric values should never be reused.
-enum class MobileSessionAppWillTerminateReceived {
+enum class MobileSessionAppWillTerminateWasReceived {
   // ApplicationWillTerminate notification was not received for this XTE.
   WasNotReceivedForXte = 0,
   // ApplicationWillTerminate notification was not received for this UTE.
@@ -143,18 +143,18 @@ MobileSessionAppState GetMobileSessionAppState(bool has_possible_explanation) {
 }
 
 // Returns value to record for
-// Stability.iOS.UTE.MobileSessionAppWillTerminateReceived histogram.
-MobileSessionAppWillTerminateReceived GetMobileSessionAppWillTerminateReceived(
-    bool has_possible_explanation) {
+// Stability.iOS.UTE.MobileSessionAppWillTerminateWasReceived histogram.
+MobileSessionAppWillTerminateWasReceived
+GetMobileSessionAppWillTerminateWasReceived(bool has_possible_explanation) {
   if (!PreviousSessionInfo.sharedInstance.applicationWillTerminateWasReceived) {
     return has_possible_explanation
-               ? MobileSessionAppWillTerminateReceived::WasNotReceivedForXte
-               : MobileSessionAppWillTerminateReceived::WasNotReceivedForUte;
+               ? MobileSessionAppWillTerminateWasReceived::WasNotReceivedForXte
+               : MobileSessionAppWillTerminateWasReceived::WasNotReceivedForUte;
   }
 
   return has_possible_explanation
-             ? MobileSessionAppWillTerminateReceived::WasReceivedForXte
-             : MobileSessionAppWillTerminateReceived::WasReceivedForUte;
+             ? MobileSessionAppWillTerminateWasReceived::WasReceivedForXte
+             : MobileSessionAppWillTerminateWasReceived::WasReceivedForUte;
 }
 
 // Logs |type| in the shutdown type histogram.
@@ -351,8 +351,8 @@ void MobileSessionShutdownMetricsProvider::ProvidePreviousSessionData(
 
     UMA_STABILITY_HISTOGRAM_ENUMERATION(
         "Stability.iOS.UTE.MobileSessionAppWillTerminateWasReceived",
-        GetMobileSessionAppWillTerminateReceived(possible_explanation),
-        MobileSessionAppWillTerminateReceived::kMaxValue);
+        GetMobileSessionAppWillTerminateWasReceived(possible_explanation),
+        MobileSessionAppWillTerminateWasReceived::kMaxValue);
 
     if (!possible_explanation && EnableSyntheticCrashReportsForUte() &&
         GetApplicationContext()->GetLocalState()->GetBoolean(

tools/metrics/histograms/histograms_xml/stability/histograms.xml

@@ -436,7 +436,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
   </summary>
 </histogram>
 
-<histogram name="Stability.iOS.UTE.MobileSessionAppWillTerminateReceived"
+<histogram name="Stability.iOS.UTE.MobileSessionAppWillTerminateWasReceived"
     enum="AppWillTerminateReceived" expires_after="2021-04-29">
   <owner>eugenebut@chromium.org</owner>
   <owner>olivierrobin@chromium.org</owner>