LayoutTests:

        Reviewed by Adam.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11449
          Type-to-select in unopened popups doesn't work with Hebrew

        * fast/forms/select-type-ahead-non-latin-expected.txt: Added.
        * fast/forms/select-type-ahead-non-latin.html: Added.

WebCore:

        Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11449
          Type-to-select in unopened popups doesn't work with Hebrew

        Test: fast/forms/select-type-ahead-non-latin.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
        isprint() condition to a Unicode isPrintableChar().



git-svn-id: svn://svn.chromium.org/blink/trunk@18779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/ChangeLog

+2007-01-11  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adam.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=11449
+          Type-to-select in unopened popups doesn't work with Hebrew
+
+        * fast/forms/select-type-ahead-non-latin-expected.txt: Added.
+        * fast/forms/select-type-ahead-non-latin.html: Added.
+
 2007-01-11  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by geoff

third_party/WebKit/LayoutTests/fast/forms/select-type-ahead-non-latin-expected.txt

+Test for http://bugs.webkit.org/show_bug.cgi?id=11449 Type-to-select in unopened popups doesn't work with Hebrew.
+
+
+SUCCESS
+

third_party/WebKit/LayoutTests/fast/forms/select-type-ahead-non-latin.html

+<p>
+    Test for <i><a href="http://bugs.webkit.org/show_bug.cgi?id=11449">http://bugs.webkit.org/show_bug.cgi?id=11449</a>
+    Type-to-select in unopened popups doesn't work with Hebrew</i>.
+</p>
+<select id="menu"><option>&#x05e9;</option><option>&#x05d3;</option><option>&#x05d2;</option><option>&#x05db;</option><option>&#x05e2;</option></select>
+<div id="result">Cannot run interactively.</div>
+<script>
+    if (window.layoutTestController) {
+        layoutTestController.dumpAsText();
+        var menu = document.getElementById("menu");
+        menu.focus();
+        eventSender.keyDown("\u05d2");
+        var result = document.getElementById("result");
+        result.innerText = menu.value == "\u05d2" ? "SUCCESS" : "FAIL";
+    }
+</script>

third_party/WebKit/WebCore/ChangeLog

+2007-01-11  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adam.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=11449
+          Type-to-select in unopened popups doesn't work with Hebrew
+
+        Test: fast/forms/select-type-ahead-non-latin.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
+        isprint() condition to a Unicode isPrintableChar().
+
 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by geoff

third_party/WebKit/WebCore/html/HTMLSelectElement.cpp

@@ -571,9 +571,9 @@ void HTMLSelectElement::defaultEventHandler(Event* evt)
     if (!evt->defaultHandled() && evt->type() == keypressEvent && evt->isKeyboardEvent()) {
         KeyboardEvent* keyboardEvent = static_cast<KeyboardEvent*>(evt);
     
-        if (!keyboardEvent->ctrlKey() && !keyboardEvent->altKey() && !keyboardEvent->metaKey()
-            && isprint(static_cast<KeyboardEvent*>(evt)->charCode())) {
-            typeAheadFind(static_cast<KeyboardEvent*>(evt));
+        if (!keyboardEvent->ctrlKey() && !keyboardEvent->altKey() && !keyboardEvent->metaKey() &&
+            isPrintableChar(keyboardEvent->charCode())) {
+            typeAheadFind(keyboardEvent);
             evt->setDefaultHandled();
             return;
         }