Fix flaky pending app RegistrationTimeout test

PendingAppManagerImplBrowserTest.RegistrationTimeout was sometimes reporting successful service worker registration, instead of the expected timeout. Early in the test, InstallApp executes a run loop. The service worker had opportunity to register during this run loop, so the WebAppRegistrationWaiter late in the test would sometimes report successful service worker registration even with a timeout of 0. We now test an app that has no service worker. Bug: 1071317 Change-Id: I75c3ca39417c70af874b1b44f1c5398864f7e1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153457 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759961}

Fix flaky pending app RegistrationTimeout test
PendingAppManagerImplBrowserTest.RegistrationTimeout was sometimes reporting successful service worker registration, instead of the expected timeout. Early in the test, InstallApp executes a run loop. The service worker had opportunity to register during this run loop, so the WebAppRegistrationWaiter late in the test would sometimes report successful service worker registration even with a timeout of 0. We now test an app that has no service worker. Bug: 1071317 Change-Id: I75c3ca39417c70af874b1b44f1c5398864f7e1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153457 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759961}
bda43c49 · Eric Willigers · Commit Bot · ebecf17e · bda43c49 · bda43c49
Commit bda43c49 authored Apr 17, 2020 by Eric Willigers Committed by Commit Bot Apr 17, 2020
3 changed files
--- a/chrome/browser/web_applications/pending_app_manager_impl_browsertest.cc
+++ b/chrome/browser/web_applications/pending_app_manager_impl_browsertest.cc
@@ -397,7 +397,7 @@ IN_PROC_BROWSER_TEST_P(PendingAppManagerImplBrowserTest, CannotFetchManifest) {
 IN_PROC_BROWSER_TEST_P(PendingAppManagerImplBrowserTest, RegistrationTimeout) {
  ASSERT_TRUE(embedded_test_server()->Start());
  PendingAppRegistrationTask::SetTimeoutForTesting(0);
-  GURL url(embedded_test_server()->GetURL("/banners/manifest_test_page.html"));
+  GURL url(embedded_test_server()->GetURL("/web_apps/no_service_worker.html"));
  CheckServiceWorkerStatus(url,
                           content::ServiceWorkerCapability::NO_SERVICE_WORKER);

--- a/chrome/test/data/web_apps/no_service_worker.html
+++ b/chrome/test/data/web_apps/no_service_worker.html
+<!DOCTYPE html>
+<html>
+<head>
+  <link rel="manifest" href="no_service_worker.json">
+  <link rel="icon" href="basic-48.png">
+</head>
+<body>
+  <h1>Web app with no service worker</h1>
+</body>
+</html>
--- a/chrome/test/data/web_apps/no_service_worker.json
+++ b/chrome/test/data/web_apps/no_service_worker.json
+{
+  "name": "Web app with no service worker",
+  "icons": [
+    {
+      "src": "basic-48.png",
+      "sizes": "48x48",
+      "type": "image/png"
+    },
+    {
+      "src": "basic-192.png",
+      "sizes": "192x192",
+      "type": "image/png"
+    }
+  ],
+  "start_url": "no_service_worker.html",
+  "display": "standalone"
+}