Commit bda68930 authored by Steven Holte's avatar Steven Holte Committed by Commit Bot

Split Empty URL to a seperate Dropped Reason

Bug: 842012
Change-Id: Ifc35114d2f1a4b6045e97aa45c1c56ed96abae19
Reviewed-on: https://chromium-review.googlesource.com/1055936Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559312}
parent 2e66dc72
...@@ -97,6 +97,7 @@ enum class DroppedDataReason { ...@@ -97,6 +97,7 @@ enum class DroppedDataReason {
EXTENSION_URLS_DISABLED = 6, EXTENSION_URLS_DISABLED = 6,
EXTENSION_NOT_SYNCED = 7, EXTENSION_NOT_SYNCED = 7,
NOT_MATCHED = 8, NOT_MATCHED = 8,
EMPTY_URL = 9,
NUM_DROPPED_DATA_REASONS NUM_DROPPED_DATA_REASONS
}; };
...@@ -342,6 +343,11 @@ void UkmRecorderImpl::UpdateSourceURL(SourceId source_id, ...@@ -342,6 +343,11 @@ void UkmRecorderImpl::UpdateSourceURL(SourceId source_id,
return; return;
} }
if (unsanitized_url.is_empty()) {
RecordDroppedSource(DroppedDataReason::EMPTY_URL);
return;
}
source_counts_.observed++; source_counts_.observed++;
if (GetSourceIdType(source_id) == SourceIdType::NAVIGATION_ID) if (GetSourceIdType(source_id) == SourceIdType::NAVIGATION_ID)
source_counts_.navigation_sources++; source_counts_.navigation_sources++;
...@@ -350,6 +356,8 @@ void UkmRecorderImpl::UpdateSourceURL(SourceId source_id, ...@@ -350,6 +356,8 @@ void UkmRecorderImpl::UpdateSourceURL(SourceId source_id,
if (!HasSupportedScheme(url)) { if (!HasSupportedScheme(url)) {
RecordDroppedSource(DroppedDataReason::UNSUPPORTED_URL_SCHEME); RecordDroppedSource(DroppedDataReason::UNSUPPORTED_URL_SCHEME);
DVLOG(2) << "Dropped Unsupported UKM URL:" << source_id << ":"
<< url.spec();
return; return;
} }
......
...@@ -45495,6 +45495,7 @@ Full version information for the fingerprint enum values: ...@@ -45495,6 +45495,7 @@ Full version information for the fingerprint enum values:
<int value="6" label="Extension URLs disabled"/> <int value="6" label="Extension URLs disabled"/>
<int value="7" label="Extension not synced"/> <int value="7" label="Extension not synced"/>
<int value="8" label="Not matched"/> <int value="8" label="Not matched"/>
<int value="9" label="Empty URL"/>
</enum> </enum>
<enum name="UkmSyncDisableInfo"> <enum name="UkmSyncDisableInfo">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment