Use TestSimpleTaskRunner::NumPendingTasks instead of GetPendingTasks().size()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent NumPendingTasks to avoid the copy.

BUG=554299

Review-Url: https://codereview.chromium.org/2335153002
Cr-Commit-Position: refs/heads/master@{#418496}

base/task/cancelable_task_tracker_unittest.cc

@@ -112,7 +112,7 @@ TEST_F(CancelableTaskTrackerTest, CancelPostedTask) {
       test_task_runner.get(), FROM_HERE, MakeExpectedNotRunClosure(FROM_HERE));
   EXPECT_NE(CancelableTaskTracker::kBadTaskId, task_id);
 
-  EXPECT_EQ(1U, test_task_runner->GetPendingTasks().size());
+  EXPECT_EQ(1U, test_task_runner->NumPendingTasks());
 
   task_tracker_.TryCancel(task_id);
 

chrome/browser/notifications/extension_welcome_notification_unittest.cc

@@ -482,7 +482,7 @@ TEST_F(ExtensionWelcomeNotificationTest, TimeExpiredNotification) {
       base::TimeDelta::FromDays(
           ExtensionWelcomeNotification::kRequestedShowTimeDays);
 
-  EXPECT_EQ(task_runner()->GetPendingTasks().size(), 1U);
+  EXPECT_EQ(task_runner()->NumPendingTasks(), 1U);
   EXPECT_EQ(task_runner()->NextPendingTaskDelay(), requested_show_time);
 
   EXPECT_EQ(message_center()->add_notification_calls(), 1);

extensions/common/one_shot_event_unittest.cc

@@ -30,9 +30,9 @@ TEST(OneShotEventTest, CallsQueue) {
   int i = 0;
   event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
   event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
-  EXPECT_EQ(0U, runner->GetPendingTasks().size());
+  EXPECT_EQ(0U, runner->NumPendingTasks());
   event.Signal();
-  ASSERT_EQ(2U, runner->GetPendingTasks().size());
+  ASSERT_EQ(2U, runner->NumPendingTasks());
   EXPECT_NE(runner->GetPendingTasks()[0].location.line_number(),
             runner->GetPendingTasks()[1].location.line_number())
       << "Make sure FROM_HERE is propagated.";
@@ -49,7 +49,7 @@ TEST(OneShotEventTest, CallsAfterSignalDontRunInline) {
 
   event.Signal();
   event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
-  EXPECT_EQ(1U, runner->GetPendingTasks().size());
+  EXPECT_EQ(1U, runner->NumPendingTasks());
   EXPECT_EQ(0, i);
   runner->RunPendingTasks();
   EXPECT_EQ(1, i);
@@ -66,7 +66,7 @@ TEST(OneShotEventTest, PostDefaultsToCurrentMessageLoop) {
   event.Post(FROM_HERE, base::Bind(&Increment, &runner_i), runner);
   event.Post(FROM_HERE, base::Bind(&Increment, &loop_i));
   event.Signal();
-  EXPECT_EQ(1U, runner->GetPendingTasks().size());
+  EXPECT_EQ(1U, runner->NumPendingTasks());
   EXPECT_EQ(0, runner_i);
   runner->RunPendingTasks();
   EXPECT_EQ(1, runner_i);
@@ -96,15 +96,15 @@ TEST(OneShotEventTest, IsSignaledAndPostsFromCallbackWork) {
   event.Signal();
 
   // CheckSignaledAndPostIncrement is queued on |runner|.
-  EXPECT_EQ(1U, runner->GetPendingTasks().size());
+  EXPECT_EQ(1U, runner->NumPendingTasks());
   EXPECT_EQ(0, i);
   runner->RunPendingTasks();
   // Increment is queued on |runner|.
-  EXPECT_EQ(1U, runner->GetPendingTasks().size());
+  EXPECT_EQ(1U, runner->NumPendingTasks());
   EXPECT_EQ(0, i);
   runner->RunPendingTasks();
   // Increment has run.
-  EXPECT_EQ(0U, runner->GetPendingTasks().size());
+  EXPECT_EQ(0U, runner->NumPendingTasks());
   EXPECT_EQ(1, i);
 }