Commit bdae6849 authored by jochen@chromium.org's avatar jochen@chromium.org

Ignore exceptions when writing breakpad symbols

There's not much we can do about this, and ignoring the exception is
better than hanging the thread.

The minidump_stackwalk binary will just ignore modules for which it
can't find symbols so not having some symbols isn't tragic.

BUG=none
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/294203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272423 0039d316-1c4b-4281-b951-d872f2087c98
parent 238dd7b5
...@@ -178,9 +178,14 @@ def GenerateSymbols(options, binaries): ...@@ -178,9 +178,14 @@ def GenerateSymbols(options, binaries):
module_line.group(1)) module_line.group(1))
mkdir_p(output_path) mkdir_p(output_path)
symbol_file = "%s.sym" % module_line.group(2) symbol_file = "%s.sym" % module_line.group(2)
f = open(os.path.join(output_path, symbol_file), 'w') try:
f.write(syms) f = open(os.path.join(output_path, symbol_file), 'w')
f.close() f.write(syms)
f.close()
except Exception, e:
# Not much we can do about this.
with print_lock:
print e
queue.task_done() queue.task_done()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment