Fix redundant field initializations

Normally custom ErrorProne checks would catch this,
but they were inadvertently disabled.
In preparation for for re-enabling these custom ErrorProne checks
this CL fixes all the redundant field initializations that have
crept into the codebase.

Trivial mechanical change

TBR=yfriedman@chromium.org

Bug: 904524
Change-Id: I96a81a1cb3b8c67bc682728aa9035c4757ed319b
Reviewed-on: https://chromium-review.googlesource.com/c/1334188
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608197}

chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java

@@ -31,7 +31,7 @@ public class FeedProcessScopeFactory {
 
     /** Flag that tracks whether we've ever been disabled via enterprise policy. Should only be
      * accessed through isFeedProcessScopeEnabled(). */
-    private static boolean sEverDisabledForPolicy = false;
+    private static boolean sEverDisabledForPolicy;
     private static PrefChangeRegistrar sPrefChangeRegistrar;
     private static FeedAppLifecycle sFeedAppLifecycle;
     private static FeedProcessScope sFeedProcessScope;

chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java

@@ -45,7 +45,7 @@ class ManualFillingMediator extends EmptyTabObserver
         implements KeyboardAccessoryCoordinator.VisibilityDelegate, View.OnLayoutChangeListener {
     private WindowAndroid mWindowAndroid;
     private Supplier<InsetObserverView> mInsetObserverViewSupplier;
-    private boolean mShouldShow = false;
+    private boolean mShouldShow;
     private final KeyboardExtensionSizeManager mKeyboardExtensionSizeManager =
             new KeyboardExtensionSizeManager();
 

chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AnimatedProgressBar.java

@@ -29,10 +29,10 @@ public class AnimatedProgressBar {
     private final int mNormalColor;
     private final int mPulsedColor;
 
-    private boolean mIsRunningProgressAnimation = false;
-    private int mLastProgress = 0;
+    private boolean mIsRunningProgressAnimation;
+    private int mLastProgress;
     private Queue<ValueAnimator> mPendingIncreaseAnimations = new ArrayDeque<>();
-    private ValueAnimator mPulseAnimation = null;
+    private ValueAnimator mPulseAnimation;
 
     public AnimatedProgressBar(MaterialProgressBar progressBar, int normalColor, int pulsedColor) {
         mProgressBar = progressBar;

chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java

@@ -101,7 +101,7 @@ class AutofillAssistantUiDelegate {
 
     private final BottomBarAnimations mBottomBarAnimations;
     private final boolean mIsRightToLeftLayout;
-    private ValueAnimator mDetailsPulseAnimation = null;
+    private ValueAnimator mDetailsPulseAnimation;
 
     private AutofillAssistantPaymentRequest mPaymentRequest;
 

chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java

@@ -33,7 +33,7 @@ public class NotificationsPreferences extends PreferenceFragment {
     // The following fields are only set if Feed is disabled, and should be null checked before
     // being used.
     private ChromeSwitchPreference mSuggestionsPref;
-    private SnippetsBridge mSnippetsBridge = null;
+    private SnippetsBridge mSnippetsBridge;
 
     @Override
     public void onCreate(Bundle savedInstanceState) {

chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabCountProvider.java

@@ -41,9 +41,9 @@ public class TabCountProvider {
      */
     private TabModelSelectorTabModelObserver mTabModelSelectorTabModelObserver;
 
-    private int mTabCount = 0;
+    private int mTabCount;
 
-    private boolean mIsIncognito = false;
+    private boolean mIsIncognito;
 
     TabCountProvider() {
         mTabCountObservers = new ObserverList<TabCountObserver>();

chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

@@ -140,7 +140,7 @@ public class NewTabPageTest {
             UrlUtils.getIsolatedTestFilePath("/chrome/test/data/android/feed/hello_world.gcl.bin");
 
     // Anything not parameterized runs with Feed disabled.
-    private boolean mInterestFeedEnabled = false;
+    private boolean mInterestFeedEnabled;
     private Tab mTab;
     private NewTabPage mNtp;
     private View mFakebox;

chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java

@@ -87,7 +87,7 @@ public class FeedActionHandlerTest {
     @Captor
     ArgumentCaptor<WebContentsObserver> mWebContentsObserverCaptor;
 
-    int mLastCommittedEntryIndex = 0;
+    int mLastCommittedEntryIndex;
     private FeedActionHandler mActionHandler;
 
     private void verifyOpenedOffline(int expectedDisposition) {

tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java

@@ -319,7 +319,7 @@ public class MainActivity extends Activity implements View.OnClickListener {
         private final String mSpeculationMode;
         private final int mDelayToMayLaunchUrl;
         private final int mDelayToLaunchUrl;
-        public boolean mWarmupCompleted = false;
+        public boolean mWarmupCompleted;
         private long mIntentSentMs = NONE;
         private long mPageLoadStartedMs = NONE;
         private long mPageLoadFinishedMs = NONE;