Commit bdcc0abb authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Sync::USS] Enable more two client bookmarks integration tests

Those have been enabled before in
f846b651
which has been reverted because
MC_MergeDifferentBMModelsModeratelyComplex
started to fail on win/asan.
https://crbug.com/875239

This CL enables the same set of tests except the failing one.

Bug: 516866
Change-Id: I86539879b95e94ed4535d4a788dd7b286760563d
Reviewed-on: https://chromium-review.googlesource.com/1193363Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586651}
parent b4b6a7dd
...@@ -455,7 +455,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -455,7 +455,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Add bookmarks with different name and same URL. // Add bookmarks with different name and same URL.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
SC_DuplicateBookmarksWithSameURL) { SC_DuplicateBookmarksWithSameURL) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1238,7 +1238,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1238,7 +1238,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_TRUE(BookmarksMatchVerifierChecker().Wait()); ASSERT_TRUE(BookmarksMatchVerifierChecker().Wait());
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_BiDirectionalPushAddingBM) { MC_BiDirectionalPushAddingBM) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1256,7 +1256,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1256,7 +1256,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_BiDirectionalPush_AddingSameBMs) { MC_BiDirectionalPush_AddingSameBMs) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1273,14 +1273,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1273,14 +1273,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_TRUE(BookmarksMatchChecker().Wait()); ASSERT_TRUE(BookmarksMatchChecker().Wait());
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_BootStrapEmptyStateEverywhere) { MC_BootStrapEmptyStateEverywhere) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AwaitQuiescence()); ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_CaseInsensitivity_InNames) { MC_Merge_CaseInsensitivity_InNames) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1302,7 +1302,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1302,7 +1302,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_SimpleMergeOfDifferentBMModels) { MC_SimpleMergeOfDifferentBMModels) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1328,7 +1328,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1328,7 +1328,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchyUnderBMBar) { MC_MergeSimpleBMHierarchyUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1351,7 +1351,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1351,7 +1351,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) { MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1369,7 +1369,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1369,7 +1369,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge bookmark folders with different bookmarks. // Merge bookmark folders with different bookmarks.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeBMFoldersWithDifferentBMs) { MC_MergeBMFoldersWithDifferentBMs) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1433,7 +1433,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1433,7 +1433,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge simple bookmark subset under bookmark folder. // Merge simple bookmark subset under bookmark folder.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchySubsetUnderBMFolder) { MC_MergeSimpleBMHierarchySubsetUnderBMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1458,7 +1458,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1458,7 +1458,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge subsets of bookmark under bookmark bar. // Merge subsets of bookmark under bookmark bar.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar) { MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1482,7 +1482,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1482,7 +1482,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge simple bookmark hierarchy under bookmark folder. // Merge simple bookmark hierarchy under bookmark folder.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_Under_BMFolder) { MC_Merge_SimpleBMHierarchy_Under_BMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1513,7 +1513,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1513,7 +1513,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
// Merge disjoint sets of bookmark hierarchy under bookmark // Merge disjoint sets of bookmark hierarchy under bookmark
// folder. // folder.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder) { MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1566,7 +1566,7 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1566,7 +1566,7 @@ IN_PROC_BROWSER_TEST_F(
} }
// Merge sets of duplicate bookmarks under bookmark bar. // Merge sets of duplicate bookmarks under bookmark bar.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar) { MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1627,7 +1627,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) { ...@@ -1627,7 +1627,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) {
} }
// Test adding duplicate folder - Both with different BMs underneath. // Test adding duplicate folder - Both with different BMs underneath.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, MC_DuplicateFolders) { IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_DuplicateFolders) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1977,7 +1978,8 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1977,7 +1978,8 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
// Trigger the server side creation of Synced Bookmarks. Ensure both clients // Trigger the server side creation of Synced Bookmarks. Ensure both clients
// remain syncing afterwards. Add bookmarks to the synced bookmarks folder // remain syncing afterwards. Add bookmarks to the synced bookmarks folder
// and ensure both clients receive the bookmark. // and ensure both clients receive the bookmark.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, CreateSyncedBookmarks) { IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
CreateSyncedBookmarks) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment