Commit bdd317a9 authored by isherman@chromium.org's avatar isherman@chromium.org

Prevent the PasswordManager from provisionally saving data from username-less forms.

Also remove an obsolete comment.

BUG=121612
TEST=none


Review URL: http://codereview.chromium.org/9950139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132323 0039d316-1c4b-4281-b951-d872f2087c98
parent 109ba9e1
......@@ -112,6 +112,10 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
if (manager->IsBlacklisted())
return;
// Bail if we're missing any of the necessary form components.
if (!manager->HasValidPasswordForm())
return;
PasswordForm provisionally_saved_form(form);
provisionally_saved_form.ssl_valid = form.origin.SchemeIsSecure() &&
!delegate_->DidLastPageLoadEncounterSSLErrors();
......@@ -184,8 +188,6 @@ void PasswordManager::OnPasswordFormsRendered(
if (provisional_save_manager_->DoesManage(*iter)) {
// The form trying to be saved has immediately re-appeared. Assume login
// failure and abort this save, by clearing provisional_save_manager_.
// Don't delete the login managers since the user may try again
// and we want to be able to save in that case.
provisional_save_manager_->SubmitFailed();
provisional_save_manager_.reset();
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment