Commit bdda84bd authored by Takashi Toyoshima's avatar Takashi Toyoshima Committed by Commit Bot

OOR-CORS: remove a wrong DCHECK that makes a test flake

OnUploadProgress() can be called even during a redirect
is not resolved. So the existing DCHECK is wrong.

Bug: 994007
Change-Id: I523b6e68dc5f7e90f0a4f8a3314450a8a34bb214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760630Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688419}
parent 32dce403
......@@ -363,7 +363,6 @@ void CorsURLLoader::OnUploadProgress(int64_t current_position,
OnUploadProgressCallback ack_callback) {
DCHECK(network_loader_);
DCHECK(forwarding_client_);
DCHECK(!deferred_redirect_url_);
forwarding_client_->OnUploadProgress(current_position, total_size,
std::move(ack_callback));
}
......
......@@ -842,13 +842,7 @@ TEST_P(SimpleURLLoaderTest, UploadShortStringWithRedirect) {
EXPECT_EQ(1, num_redirects);
}
#if defined(OS_FUCHSIA)
// TODO(crbug.com/994007): The test crashes on Fuchsia.
#define MAYBE_UploadLongStringWithRedirect DISABLED_UploadLongStringWithRedirect
#else
#define MAYBE_UploadLongStringWithRedirect UploadLongStringWithRedirect
#endif
TEST_P(SimpleURLLoaderTest, MAYBE_UploadLongStringWithRedirect) {
TEST_P(SimpleURLLoaderTest, UploadLongStringWithRedirect) {
// Use a 307 redirect to preserve the body across the redirect.
std::unique_ptr<SimpleLoaderTestHelper> test_helper = CreateHelperForURL(
test_server_.GetURL("/server-redirect-307?" +
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment