Commit bde2d765 authored by Varun Khaneja's avatar Varun Khaneja Committed by Commit Bot

Mark various unused Safe Browsing histograms as deprecated.

Bug: 673607, 728827, 725336, 705809
Change-Id: Ia1418bba1f6ab0956637de3677a2f0fbef48adc9
Reviewed-on: https://chromium-review.googlesource.com/1233356Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593018}
parent c74ed76f
...@@ -87669,6 +87669,9 @@ uploading your change for review. ...@@ -87669,6 +87669,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.AddPrefixes"> <histogram name="SB2.AddPrefixes">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The number of add prefixes stored in the database after the last update. The number of add prefixes stored in the database after the last update.
...@@ -87718,6 +87721,9 @@ uploading your change for review. ...@@ -87718,6 +87721,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.BuildFilter" units="ms"> <histogram name="SB2.BuildFilter" units="ms">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The time that it took to regenerate the filter after we have received all The time that it took to regenerate the filter after we have received all
...@@ -87738,6 +87744,9 @@ uploading your change for review. ...@@ -87738,6 +87744,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.BuildReadKilobytes" units="KB"> <histogram name="SB2.BuildReadKilobytes" units="KB">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The number of kilobytes read by the browser process during the filter The number of kilobytes read by the browser process during the filter
...@@ -87746,6 +87755,9 @@ uploading your change for review. ...@@ -87746,6 +87755,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.BuildReadOperations"> <histogram name="SB2.BuildReadOperations">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The number of read operations issued by the browser process during the The number of read operations issued by the browser process during the
...@@ -87766,6 +87778,9 @@ uploading your change for review. ...@@ -87766,6 +87778,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.BuildWriteKilobytes" units="KB"> <histogram name="SB2.BuildWriteKilobytes" units="KB">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The number of kilobytes written by the browser process during the filter The number of kilobytes written by the browser process during the filter
...@@ -87774,6 +87789,9 @@ uploading your change for review. ...@@ -87774,6 +87789,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.BuildWriteOperations"> <histogram name="SB2.BuildWriteOperations">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The number of write operations issued by the browser process during the The number of write operations issued by the browser process during the
...@@ -87782,6 +87800,9 @@ uploading your change for review. ...@@ -87782,6 +87800,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.ChunkInsert" units="ms"> <histogram name="SB2.ChunkInsert" units="ms">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The time that it takes to write one redirect URL (which can contain multiple The time that it takes to write one redirect URL (which can contain multiple
...@@ -87790,6 +87811,9 @@ uploading your change for review. ...@@ -87790,6 +87811,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.ChunkRequest" units="ms"> <histogram name="SB2.ChunkRequest" units="ms">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The network time between the request and response for a chunk. The network time between the request and response for a chunk.
...@@ -87797,6 +87821,9 @@ uploading your change for review. ...@@ -87797,6 +87821,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.ChunkSize" units="bytes"> <histogram name="SB2.ChunkSize" units="bytes">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary>The size of one chunk URL.</summary> <summary>The size of one chunk URL.</summary>
</histogram> </histogram>
...@@ -87811,6 +87838,9 @@ uploading your change for review. ...@@ -87811,6 +87838,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.DatabaseFailure" enum="SB2DatabaseFailure"> <histogram name="SB2.DatabaseFailure" enum="SB2DatabaseFailure">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary>Track failures when updating the safe-browsing database.</summary> <summary>Track failures when updating the safe-browsing database.</summary>
</histogram> </histogram>
...@@ -87826,6 +87856,9 @@ uploading your change for review. ...@@ -87826,6 +87856,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.DatabaseOpen" units="ms"> <histogram name="SB2.DatabaseOpen" units="ms">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The time it takes to initialize the SafeBrowsing storage backend, in The time it takes to initialize the SafeBrowsing storage backend, in
...@@ -87834,6 +87867,9 @@ uploading your change for review. ...@@ -87834,6 +87867,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.DatabaseSizeKilobytes" units="KB"> <histogram name="SB2.DatabaseSizeKilobytes" units="KB">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>gab@chromium.org</owner> <owner>gab@chromium.org</owner>
<summary> <summary>
The size of one of the SafeBrowsing database file on disk in kilobytes, The size of one of the SafeBrowsing database file on disk in kilobytes,
...@@ -87843,6 +87879,9 @@ uploading your change for review. ...@@ -87843,6 +87879,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.DatabaseUpdateKilobytes" units="KB"> <histogram name="SB2.DatabaseUpdateKilobytes" units="KB">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The size of the update file before merging with the database file, in The size of the update file before merging with the database file, in
...@@ -87927,6 +87966,9 @@ uploading your change for review. ...@@ -87927,6 +87966,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.DownloadHashCheckDuration" units="ms"> <histogram name="SB2.DownloadHashCheckDuration" units="ms">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
The time it takes for SafeBrowsing to check hash of a download file. The time it takes for SafeBrowsing to check hash of a download file.
...@@ -87989,6 +88031,9 @@ uploading your change for review. ...@@ -87989,6 +88031,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.FilterLoad" enum="SB2FilterLoad"> <histogram name="SB2.FilterLoad" enum="SB2FilterLoad">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary>Which filter file the database loaded from disk.</summary> <summary>Which filter file the database loaded from disk.</summary>
</histogram> </histogram>
...@@ -88036,6 +88081,9 @@ uploading your change for review. ...@@ -88036,6 +88081,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.FormatEvent" enum="SB2FormatEvent"> <histogram name="SB2.FormatEvent" enum="SB2FormatEvent">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
Collection of boolean events for SafeBrowsingFileStore instances. Includes Collection of boolean events for SafeBrowsingFileStore instances. Includes
...@@ -88045,6 +88093,9 @@ uploading your change for review. ...@@ -88045,6 +88093,9 @@ uploading your change for review.
<histogram name="SB2.GetChunkResponseOrErrorCode" <histogram name="SB2.GetChunkResponseOrErrorCode"
enum="CombinedHttpResponseAndNetErrorCode"> enum="CombinedHttpResponseAndNetErrorCode">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@google.com</owner> <owner>vakh@google.com</owner>
<summary> <summary>
Response or error codes from the SafeBrowsing service. Logged after a Response or error codes from the SafeBrowsing service. Logged after a
...@@ -88084,6 +88135,9 @@ uploading your change for review. ...@@ -88084,6 +88135,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.GetHashResult" enum="SB2GetHashResult"> <histogram name="SB2.GetHashResult" enum="SB2GetHashResult">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>mattm@chromium.org</owner> <owner>mattm@chromium.org</owner>
<summary> <summary>
Track return status from GetHash attempts (STATUS_200, STATUS_204, Track return status from GetHash attempts (STATUS_200, STATUS_204,
...@@ -88098,6 +88152,9 @@ uploading your change for review. ...@@ -88098,6 +88152,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.GetHashResultDownload" enum="SB2GetHashResult"> <histogram name="SB2.GetHashResultDownload" enum="SB2GetHashResult">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>mattm@chromium.org</owner> <owner>mattm@chromium.org</owner>
<summary> <summary>
Track return status from GetHash attempts (STATUS_200, STATUS_204, Track return status from GetHash attempts (STATUS_200, STATUS_204,
...@@ -88263,6 +88320,9 @@ uploading your change for review. ...@@ -88263,6 +88320,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.OutShardShifts"> <histogram name="SB2.OutShardShifts">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
Indicates how sharded safe-browsing on-disk stores are. Values like 0 to 4 Indicates how sharded safe-browsing on-disk stores are. Values like 0 to 4
...@@ -88719,6 +88779,9 @@ uploading your change for review. ...@@ -88719,6 +88779,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.StoreVersionRead"> <histogram name="SB2.StoreVersionRead">
<obsolete>
Deprecated after the launch of PVer4 in M57.
</obsolete>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary>Version read from the store file.</summary> <summary>Version read from the store file.</summary>
</histogram> </histogram>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment