Commit bde9a6dc authored by Brandon Wylie's avatar Brandon Wylie Committed by Commit Bot

Cleanup tab and activity in TabModalLifetimeHandler#destroy

Bug: 1116167
Change-Id: I4187c9a7fe3434bd3de5177913a0d5f34291a81b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358817Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798936}
parent a762394a
......@@ -50,7 +50,7 @@ public class TabModalLifetimeHandler implements NativeInitObserver, Destroyable
}
};
private final ChromeActivity mActivity;
private ChromeActivity mActivity;
private final ModalDialogManager mManager;
private final Supplier<ComposedBrowserControlsVisibilityDelegate> mAppVisibilityDelegate;
private final Supplier<TabObscuringHandler> mTabObscuringHandlerSupplier;
......@@ -131,6 +131,12 @@ public class TabModalLifetimeHandler implements NativeInitObserver, Destroyable
public void destroy() {
if (mTabModelObserver != null) mTabModelObserver.destroy();
if (mPresenter != null) mPresenter.destroy();
if (mActiveTab != null) {
mActiveTab.removeObserver(mTabObserver);
mActiveTab = null;
}
mActivity = null;
}
/** Update whether the {@link ModalDialogManager} should suspend tab modal dialogs. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment