Commit be23baef authored by David Jacobo's avatar David Jacobo Committed by Commit Bot

Fix typo and add comments on confusing params

Bug: None
Test: Build, doesn't modify funcionality.
Change-Id: I5c741baea2e143884ca750eafac1070fd19c0e8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609592
Commit-Queue: David Jacobo <djacobo@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Auto-Submit: David Jacobo <djacobo@chromium.org>
Reviewed-by: default avatarMaggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659338}
parent 17fc5bbb
......@@ -184,7 +184,7 @@ bool ArcIntentPickerAppFetcher::IsAppAvailableForTesting(
// static
size_t ArcIntentPickerAppFetcher::FindPreferredAppForTesting(
const std::vector<mojom::IntentHandlerInfoPtr>& app_candidates) {
return FindPreferredApp(app_candidates, GURL());
return FindPreferredApp(app_candidates, /*url_for_logging=*/GURL());
}
ArcIntentPickerAppFetcher::~ArcIntentPickerAppFetcher() = default;
......@@ -234,7 +234,7 @@ void ArcIntentPickerAppFetcher::OnAppCandidatesReceivedForNavigation(
// created iff there are ARC apps which can actually handle the given URL.
DVLOG(1) << "There are no app candidates for this URL: " << url;
chromeos::ChromeOsAppsNavigationThrottle::RecordUma(
std::string(), apps::mojom::AppType::kUnknown,
/*selected_app_package=*/std::string(), apps::mojom::AppType::kUnknown,
apps::IntentPickerCloseReason::PICKER_ERROR,
/*should_persist=*/false);
std::move(callback).Run(apps::AppsNavigationAction::RESUME, {});
......@@ -339,7 +339,7 @@ void ArcIntentPickerAppFetcher::GetArcAppIcons(
if (!intent_helper_bridge) {
LOG(ERROR) << "Cannot get an instance of ArcIntentHelperBridge";
chromeos::ChromeOsAppsNavigationThrottle::RecordUma(
std::string(), apps::mojom::AppType::kUnknown,
/*selected_app_package=*/std::string(), apps::mojom::AppType::kUnknown,
apps::IntentPickerCloseReason::PICKER_ERROR,
/*should_persist=*/false);
std::move(callback).Run({});
......
......@@ -41,7 +41,7 @@ class ArcIntentPickerAppFetcher : content::WebContentsObserver {
// the preferred app (if it exists) will be automatically launched.
static bool WillGetArcAppsForNavigation(content::NavigationHandle* handle,
apps::AppsNavigationCallback callback,
bool should_aunch_preferred_app);
bool should_launch_preferred_app);
// Called to launch an ARC app if it was selected by the user, and persist the
// preference to launch or stay in Chrome if |should_persist| is true. Returns
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment