Skip to content

GitLab

T
tangled
Commit be34ad2a authored by Yi Gu's avatar Yi Gu Committed by Commit Bot
Browse files
Options

[animation worklet] Delete duplicated layout test 

Previously worklet-animation-style-update.html used runChecksWithRAF to
test the output because it was the only way to check getComputedStyle.
Now that getComputedStyle is supported via peeking via main thread and
the behavior has been tested in animator-animate.html, we no longer
need this test.

Bug: 900356
Change-Id: I104f271c562c6718c664dc1de264018f928eb546
Reviewed-on: https://chromium-review.googlesource.com/c/1319511Reviewed-by: default avatarMajid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607662}
parent ca2f043a
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 72 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ be34ad2a
...@@ -5378,7 +5378,6 @@ crbug.com/867668 [ Linux ] virtual/user-activation-v2/fast/events/middleClickAut ...@@ -5378,7 +5378,6 @@ crbug.com/867668 [ Linux ] virtual/user-activation-v2/fast/events/middleClickAut
crbug.com/899222 [ Linux Win ] virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-scrollbar-touchpad-fling.html [ Failure Pass ] crbug.com/899222 [ Linux Win ] virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-scrollbar-touchpad-fling.html [ Failure Pass ]
crbug.com/899222 [ Linux Win ] virtual/user-activation-v2/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html [ Failure Pass ] crbug.com/899222 [ Linux Win ] virtual/user-activation-v2/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html [ Failure Pass ]
crbug.com/899222 [ Linux Win ] virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html [ Failure Pass ] crbug.com/899222 [ Linux Win ] virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html [ Failure Pass ]
crbug.com/900356 [ Win ] virtual/threaded/animations/animationworklet/worklet-animation-style-update.html [ Failure Pass ]
# Sheriff 2018-10-31 # Sheriff 2018-10-31
crbug.com/900326 [ Win7 Mac10.12 ] http/tests/devtools/network/preview-searchable.js [ Timeout Pass ] crbug.com/900326 [ Win7 Mac10.12 ] http/tests/devtools/network/preview-searchable.js [ Timeout Pass ]
......
third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-style-update-expected.txt deleted 100644 → 0
View file @ ca2f043a
PASS - "opacity" property for "box" element at 0.2s saw something close to: 0.5
PASS - "transform.5" property for "box" element at 0.2s saw something close to: 100
PASS - "opacity" property for "box" element at 0.5s saw something close to: 0.5
PASS - "transform.5" property for "box" element at 0.5s saw something close to: 100
PASS - "opacity" property for "box" element at 1s saw something close to: 0.5
PASS - "transform.5" property for "box" element at 1s saw something close to: 100
third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-style-update.html deleted 100644 → 0
View file @ ca2f043a
<!DOCTYPE html>
<style>
#box {
width: 100px;
height: 100px;
background-color: #00ff00;
}
</style>
<div id="box"></div>
<script id="visual_update" type="text/worklet">
registerAnimator("test_animator", class {
animate(currentTime, effect) {
effect.localTime = 500;
}
});
</script>
<script src="resources/animation-worklet-tests.js"></script>
<script src="../resources/animation-test-helpers.js"></script>
<script>
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
runInAnimationWorklet(
document.getElementById('visual_update').textContent
).then(() => {
const box = document.getElementById('box');
const effect = new KeyframeEffect(box,
[
{ transform: 'translateY(0px)', opacity: 1},
{ transform: 'translateY(200px)', opacity: 0}
], {
duration: 1000,
fill: "forwards"
}
);
const animation = new WorkletAnimation('test_animator', [effect], document.timeline, {});
animation.play();
window.animStartTime = performance.now();
const expectedValues = [
// [time, element-id, property, expected-value, tolerance]
[0.2, "box", "opacity", 0.5, 0.05],
[0.5, "box", "opacity", 0.5, 0.05],
[1, "box", "opacity", 0.5, 0.05],
[0.2, "box", "transform.5", 100, 5],
[0.5, "box", "transform.5", 100, 5],
[1, "box", "transform.5", 100, 5],
];
const checks = convertExpectationsToChecks(expectedValues);
runChecksWithRAF(checks);
});
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment