Commit be460e57 authored by Nidhi Jaju's avatar Nidhi Jaju Committed by Commit Bot

Revert "Remove NotEnumerable from Transform Streams WebIDL"

This reverts commit b52b97cb.

Reason for revert: It is breaking external/wpt/streams/idlharness.any.html based on bisection.

Original change's description:
> Remove NotEnumerable from Transform Streams WebIDL
>
> According to https://github.com/whatwg/streams/pull/1035, all methods
> and accessors are now enumerable, per Web IDL defaults, instead of
> non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can
> be removed from the Streams WebIDL files. This CL specifically
> removes them from transform streams.
>
> Bug: 1093862
> Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006
> Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819230}

TBR=ricea@chromium.org,nidhijaju@google.com

Change-Id: I7176391031e4bbf89960fe6d7f358a520d06dd21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1093862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487745Reviewed-by: default avatarFergal Daly <fergal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819275}
parent 41488e3b
...@@ -9,6 +9,6 @@ ...@@ -9,6 +9,6 @@
[CallWith=ScriptState, RaisesException] constructor(optional any transformer, [CallWith=ScriptState, RaisesException] constructor(optional any transformer,
optional any writableStrategy, optional any writableStrategy,
optional any readableStrategy); optional any readableStrategy);
readonly attribute ReadableStream readable; [NotEnumerable] readonly attribute ReadableStream readable;
readonly attribute WritableStream writable; [NotEnumerable] readonly attribute WritableStream writable;
}; };
...@@ -6,9 +6,9 @@ ...@@ -6,9 +6,9 @@
// https://streams.spec.whatwg.org/#rs-default-controller-class-definition // https://streams.spec.whatwg.org/#rs-default-controller-class-definition
interface TransformStreamDefaultController { interface TransformStreamDefaultController {
readonly attribute double? desiredSize; [NotEnumerable] readonly attribute double? desiredSize;
[CallWith=ScriptState, RaisesException] void enqueue( [CallWith=ScriptState, NotEnumerable, RaisesException] void enqueue(
optional any chunk); optional any chunk);
[CallWith=ScriptState] void error(optional any reason); [CallWith=ScriptState, NotEnumerable] void error(optional any reason);
[CallWith=ScriptState] void terminate(); [CallWith=ScriptState, NotEnumerable] void terminate();
}; };
This is a testharness.js-based test. This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup PASS idl_test setup
PASS idl_test validation PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
...@@ -176,8 +176,8 @@ PASS TransformStream interface object name ...@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute writable FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream() PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream() PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
This is a testharness.js-based test. This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup PASS idl_test setup
PASS idl_test validation PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
...@@ -176,8 +176,8 @@ PASS TransformStream interface object name ...@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute writable FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream() PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream() PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
This is a testharness.js-based test. This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup PASS idl_test setup
PASS idl_test validation PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
...@@ -176,8 +176,8 @@ PASS TransformStream interface object name ...@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute writable FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream() PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream() PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
This is a testharness.js-based test. This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup PASS idl_test setup
PASS idl_test validation PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
...@@ -176,8 +176,8 @@ PASS TransformStream interface object name ...@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute writable FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream() PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream() PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment