Commit be50aafa authored by tsergeant's avatar tsergeant Committed by Commit bot

Revert of Enable crash symbols unit test for Mac OSX. (patchset #4 id:60001 of...

Revert of Enable crash symbols unit test for Mac OSX. (patchset #4 id:60001 of https://codereview.chromium.org/1586143003/ )

Reason for revert:
This patch appears to be causing failures in telemetry_perf_unittests on Mac-10.9:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/18194

Original issue's description:
> Enable crash symbols unit test for Mac OSX.
>
> R=nednguyen@google.com
> BUG=563716
>
> Committed: https://crrev.com/7dfa2f79c2fda175f1202cac8d5a51d1e64a2171
> Cr-Commit-Position: refs/heads/master@{#370745}

TBR=nednguyen@google.com,avi@chromium.org,dyen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=563716

Review URL: https://codereview.chromium.org/1616743004

Cr-Commit-Position: refs/heads/master@{#370814}
parent 7b4108cf
......@@ -20,9 +20,9 @@ class TabStackTraceTest(tab_test_case.TabTestCase):
self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))
# Currently stack traces do not work on windows: http://crbug.com/476110
# Currently symbols do not work on swarming: http://crbug.com/563716
# Linux stack traces depends on fission support: http://crbug.com/405623
@decorators.Enabled('mac')
@decorators.Disabled('snowleopard')
@decorators.Disabled('all')
def testCrashSymbols(self):
try:
self._tab.Navigate('chrome://crash', timeout=5)
......
......@@ -47,12 +47,7 @@ def GetSymbolBinary(executable, os_name):
'Chromium Framework.framework',
'Chromium Framework')
if os.path.isfile(framework_file):
# Sometimes dyld returns symbols for a different file. Emulate what it
# does here by using the same mechanism to find the binary file.
import fcntl
F_GETPATH = 50
with open(framework_file, 'rb') as f:
return fcntl.fcntl(f.fileno(), F_GETPATH, b'\0' * 1024).rstrip(b'\0')
return framework_file
return executable
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment