Commit be5a0f0c authored by Javier Fernández García-Boente's avatar Javier Fernández García-Boente Committed by Chromium LUCI CQ

Fix an error in the eol-bidi-spaces-003 test

The original test we landed in r824804 was not using the property we
wanted to test (white-space: pre-wrap) and there was no space at all,
which was key to reproduce the issue.

This CL updates the test, keeping both expected files, since FF needs
an alternate result due to collapsing trailing spaces. It's worth
mentioning that FF fails with this new test, but I think it's due an
actual FF bug.

Bug: 316409, 1142926
Change-Id: I6eafcf5edc5350c6ccfd227d5cc89ef2b47ed1a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573081Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#837026}
parent 5cd4a47a
...@@ -18,10 +18,11 @@ ...@@ -18,10 +18,11 @@
background: green; background: green;
width: 4ch; width: 4ch;
white-space: pre-wrap;
}
span {
background: blue;
} }
.blue { color: blue; }
.bgblue { background-color: blue; }
.space { color: transparent; }
</style> </style>
<p>Test passes if a blue box (the white space) is visible at the left start in first line.</p> <p>Test passes if a blue box (the white space) is visible at the left start in first line.</p>
<div>ب<span class="bgblue"><span class="blue">X</span>OP</span><span class="space">X<br>XXX</span>D</div> <div>ب <span>OP</span><span> </span>D</div>
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
} }
.blue { color: blue; } .blue { color: blue; }
.space { color: transparent; } .space { color: transparent; }
.text { background: blue; }
</style> </style>
<p>Test passes if a blue box (the white space) is visible at the left start in first line.</p> <p>Test passes if a blue box (the white space) is visible at the left start in first line.</p>
<div>ب<span class="blue">X</span>OP<span class="space">X<br>XXX</span>D</div> <div>ب<span class="blue">X</span><span class="text">OP</span><span class="space">X<br>XXX</span>D</div>
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
} }
.blue { color: blue; } .blue { color: blue; }
.space { color: transparent; } .space { color: transparent; }
.text { background: blue; }
</style> </style>
<p>Test passes if a blue box (the white space) is visible at the left start in first line.</p> <p>Test passes if a blue box (the white space) is visible at the left start in first line.</p>
<div>ب<span class="blue">X</span>OP<span class="space">X<br>XXX</span>D</div> <div>ب<span class="blue">X</span><span class="text">OP</span><span class="space">X<br>XXX</span>D</div>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment