[omnibox] Enable all default providers for NTP realbox.
When NTP realbox was initially implemented, we didn't use the default provider list, and instead opted to create a manual whitelist of enabled providers. Original CL for context: https://chromium-review.googlesource.com/c/chromium/src/+/1761688/22/chrome/browser/ui/search/search_tab_helper.cc#558 Now that we are aiming to bring NTP realbox to feature parity with the actual omnibox, I suggest adopting this two-prong strategy. 1. Aggressively enable all the same providers in realbox as in the omnibox. They should work in principle. 2. Make NTP realbox work with chrome://omnibox so we can identify and fix any weird behavior. See: https://bugs.chromium.org/p/chromium/issues/detail?id=1058486 Here's the status on the four newly enabled suggestion types: 1. On Device Head - seems to work fine. 2. Document Provider - seems to work fine, although the icons don't have the nice custom document icons yet. Not a blocker IMO. 3. KeywordProvider - I haven't noticed it activate on NTP realbox even when enabled. I think since we have forbidden keyword operations on AutocompleteInput, it's early exiting. We will need to enable chrome://omnibox for NTP realbox to verify this. 4. Shortcuts - I can't see how this could cause a problem, but again, we will need chrome://omnibox to verify its behavior in realbox. Bug: 1039357 Change-Id: Ibf2b2ec08a8f718c57f3af9456a7457185d67d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088347Reviewed-by:Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#747806}
Showing
Please register or sign in to comment