Commit bea9ac06 authored by Yu Han's avatar Yu Han Committed by Commit Bot

Add UseCounter for ImperativeSlotAPI

This previously had no use counter.

I'm adding NOTRY here because branch day seems to be an
impossible day to land changes to enums.xml. Hopefully this
sails through. Feel free to revert if this breaks something.
NOTRY=true

Bug: 869308
Change-Id: Ic81d9620f34b8fe0998f8f6e7cb9d209b028e6a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367474
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800328}
parent 6eea6044
...@@ -2768,6 +2768,7 @@ enum WebFeature { ...@@ -2768,6 +2768,7 @@ enum WebFeature {
kRTCIceCandidatePort = 3439, kRTCIceCandidatePort = 3439,
kRTCIceCandidateRelatedAddress = 3440, kRTCIceCandidateRelatedAddress = 3440,
kRTCIceCandidateRelatedPort = 3441, kRTCIceCandidateRelatedPort = 3441,
kSlotAssignNode = 3442,
// Add new features immediately above this line. Don't change assigned // Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots. // numbers of any item, and don't reuse removed slots.
......
...@@ -196,6 +196,7 @@ void HTMLSlotElement::assign(HeapVector<Member<Node>> nodes, ...@@ -196,6 +196,7 @@ void HTMLSlotElement::assign(HeapVector<Member<Node>> nodes,
if (!CheckNodesValidity(nodes, exception_state)) if (!CheckNodesValidity(nodes, exception_state))
return; return;
UseCounter::Count(GetDocument(), WebFeature::kSlotAssignNode);
ContainingShadowRoot()->GetSlotAssignment().ClearCandidateNodes( ContainingShadowRoot()->GetSlotAssignment().ClearCandidateNodes(
assigned_nodes_candidates_); assigned_nodes_candidates_);
HeapLinkedHashSet<Member<Node>> candidates; HeapLinkedHashSet<Member<Node>> candidates;
......
...@@ -28873,6 +28873,7 @@ Called by update_use_counter_feature_enum.py.--> ...@@ -28873,6 +28873,7 @@ Called by update_use_counter_feature_enum.py.-->
<int value="3439" label="RTCIceCandidatePort"/> <int value="3439" label="RTCIceCandidatePort"/>
<int value="3440" label="RTCIceCandidateRelatedAddress"/> <int value="3440" label="RTCIceCandidateRelatedAddress"/>
<int value="3441" label="RTCIceCandidateRelatedPort"/> <int value="3441" label="RTCIceCandidateRelatedPort"/>
<int value="3442" label="SlotAssignNode"/>
</enum> </enum>
<enum name="FeaturePolicyAllowlistType"> <enum name="FeaturePolicyAllowlistType">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment