Skip to content

GitLab

T
tangled
Commit bee91954 authored by Tom Sepez's avatar Tom Sepez Committed by Commit Bot
Browse files
Options

Conditionalize PDFium fuzzers on pdf_enable_v8 GN variable 

Otherwise setting pdf_enable_v8=false breaks chrome build.

Change-Id: I86c3d369b4142ad05a986363839cbc6961772bc9
Reviewed-on: https://chromium-review.googlesource.com/c/1356010
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612435}
parent e8e8e4be
Hide whitespace changes
Inline Side-by-side
Showing with 128 additions and 122 deletions
pdf/pdfium/fuzzers/BUILD.gn
View file @ bee91954
...@@ -6,8 +6,8 @@ ...@@ -6,8 +6,8 @@
# When adding a fuzzer_test target make sure to add it to the group # When adding a fuzzer_test target make sure to add it to the group
# 'pdf_fuzzers' # 'pdf_fuzzers'
import("//testing/test.gni")
import("//testing/libfuzzer/fuzzer_test.gni") import("//testing/libfuzzer/fuzzer_test.gni")
import("//testing/test.gni")
import("//third_party/pdfium/pdfium.gni") import("//third_party/pdfium/pdfium.gni")
group("fuzzers") { group("fuzzers") {
...@@ -16,7 +16,6 @@ group("fuzzers") { ...@@ -16,7 +16,6 @@ group("fuzzers") {
group("pdf_fuzzers") { group("pdf_fuzzers") {
testonly = true testonly = true
deps = [ deps = [
":pdf_cjs_util_fuzzer",
":pdf_cmap_fuzzer", ":pdf_cmap_fuzzer",
":pdf_codec_a85_fuzzer", ":pdf_codec_a85_fuzzer",
":pdf_codec_fax_fuzzer", ":pdf_codec_fax_fuzzer",
...@@ -24,7 +23,6 @@ group("pdf_fuzzers") { ...@@ -24,7 +23,6 @@ group("pdf_fuzzers") {
":pdf_codec_jbig2_fuzzer", ":pdf_codec_jbig2_fuzzer",
":pdf_codec_rle_fuzzer", ":pdf_codec_rle_fuzzer",
":pdf_font_fuzzer", ":pdf_font_fuzzer",
":pdf_fx_date_helpers_fuzzer",
":pdf_hint_table_fuzzer", ":pdf_hint_table_fuzzer",
":pdf_jpx_fuzzer", ":pdf_jpx_fuzzer",
":pdf_psengine_fuzzer", ":pdf_psengine_fuzzer",
...@@ -32,30 +30,36 @@ group("pdf_fuzzers") { ...@@ -32,30 +30,36 @@ group("pdf_fuzzers") {
":pdf_xml_fuzzer", ":pdf_xml_fuzzer",
":pdfium_fuzzer", ":pdfium_fuzzer",
] ]
if (pdf_enable_xfa) { if (pdf_enable_v8) {
deps += [ deps += [
":pdf_bidi_fuzzer", ":pdf_cjs_util_fuzzer",
":pdf_cfx_barcode_fuzzer", ":pdf_fx_date_helpers_fuzzer",
":pdf_codec_jpeg_fuzzer",
":pdf_css_fuzzer",
":pdf_fm2js_fuzzer",
":pdf_formcalc_fuzzer",
":pdfium_xfa_fuzzer",
] ]
if (pdf_enable_xfa_bmp) { if (pdf_enable_xfa) {
deps += [ ":pdf_codec_bmp_fuzzer" ]
}
if (pdf_enable_xfa_gif) {
deps += [ deps += [
":pdf_codec_gif_fuzzer", ":pdf_bidi_fuzzer",
":pdf_lzw_fuzzer", ":pdf_cfx_barcode_fuzzer",
":pdf_codec_jpeg_fuzzer",
":pdf_css_fuzzer",
":pdf_fm2js_fuzzer",
":pdf_formcalc_fuzzer",
":pdfium_xfa_fuzzer",
] ]
} if (pdf_enable_xfa_bmp) {
if (pdf_enable_xfa_png) { deps += [ ":pdf_codec_bmp_fuzzer" ]
deps += [ ":pdf_codec_png_fuzzer" ] }
} if (pdf_enable_xfa_gif) {
if (pdf_enable_xfa_tiff) { deps += [
deps += [ ":pdf_codec_tiff_fuzzer" ] ":pdf_codec_gif_fuzzer",
":pdf_lzw_fuzzer",
]
}
if (pdf_enable_xfa_png) {
deps += [ ":pdf_codec_png_fuzzer" ]
}
if (pdf_enable_xfa_tiff) {
deps += [ ":pdf_codec_tiff_fuzzer" ]
}
} }
} }
} }
...@@ -69,13 +73,6 @@ fuzzer_test("pdfium_fuzzer") { ...@@ -69,13 +73,6 @@ fuzzer_test("pdfium_fuzzer") {
seed_corpus = "//third_party/pdfium/testing/resources" seed_corpus = "//third_party/pdfium/testing/resources"
} }
fuzzer_test("pdf_cjs_util_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_cjs_util_fuzzer_src",
]
}
fuzzer_test("pdf_cmap_fuzzer") { fuzzer_test("pdf_cmap_fuzzer") {
sources = [] sources = []
deps = [ deps = [
...@@ -119,13 +116,6 @@ fuzzer_test("pdf_codec_jbig2_fuzzer") { ...@@ -119,13 +116,6 @@ fuzzer_test("pdf_codec_jbig2_fuzzer") {
] ]
} }
fuzzer_test("pdf_fx_date_helpers_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_fx_date_helpers_fuzzer_src",
]
}
fuzzer_test("pdf_font_fuzzer") { fuzzer_test("pdf_font_fuzzer") {
sources = [] sources = []
deps = [ deps = [
...@@ -170,117 +160,133 @@ fuzzer_test("pdf_xml_fuzzer") { ...@@ -170,117 +160,133 @@ fuzzer_test("pdf_xml_fuzzer") {
dict = "dicts/pdf_xml.dict" dict = "dicts/pdf_xml.dict"
} }
if (pdf_enable_xfa) { if (pdf_enable_v8) {
if (pdf_enable_xfa_bmp) { fuzzer_test("pdf_cjs_util_fuzzer") {
fuzzer_test("pdf_codec_bmp_fuzzer") { sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_cjs_util_fuzzer_src",
]
}
fuzzer_test("pdf_fx_date_helpers_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_fx_date_helpers_fuzzer_src",
]
}
if (pdf_enable_xfa) {
if (pdf_enable_xfa_bmp) {
fuzzer_test("pdf_codec_bmp_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_bmp_fuzzer_src",
]
seed_corpus = "corpora/pdf_codec_bmp"
}
}
if (pdf_enable_xfa_gif) {
fuzzer_test("pdf_codec_gif_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_gif_fuzzer_src",
]
dict = "dicts/pdf_codec_gif.dict"
seed_corpus = "corpora/pdf_codec_gif"
}
}
fuzzer_test("pdf_codec_jpeg_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_bmp_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdf_codec_jpeg_fuzzer_src",
] ]
seed_corpus = "corpora/pdf_codec_bmp" dict = "dicts/pdf_codec_jpeg.dict"
seed_corpus = "corpora/pdf_codec_jpeg"
} }
}
if (pdf_enable_xfa_gif) { if (pdf_enable_xfa_png) {
fuzzer_test("pdf_codec_gif_fuzzer") { fuzzer_test("pdf_codec_png_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_png_fuzzer_src",
]
dict = "dicts/pdf_codec_png.dict"
seed_corpuses = [
"corpora/pdf_codec_png",
"//components/viz/test/data",
"//third_party/blink/web_tests/images/png-suite/samples",
"//third_party/blink/web_tests/images/resources/pngfuzz",
]
}
}
if (pdf_enable_xfa_tiff) {
fuzzer_test("pdf_codec_tiff_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_tiff_fuzzer_src",
]
dict = "dicts/pdf_codec_tiff.dict"
seed_corpus = "corpora/pdf_codec_tiff"
}
}
fuzzer_test("pdf_css_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_gif_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdf_css_fuzzer_src",
] ]
dict = "dicts/pdf_codec_gif.dict" dict = "dicts/pdf_css.dict"
seed_corpus = "corpora/pdf_codec_gif"
} }
}
fuzzer_test("pdf_codec_jpeg_fuzzer") { fuzzer_test("pdf_fm2js_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_jpeg_fuzzer_src",
]
dict = "dicts/pdf_codec_jpeg.dict"
seed_corpus = "corpora/pdf_codec_jpeg"
}
if (pdf_enable_xfa_png) {
fuzzer_test("pdf_codec_png_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_png_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdf_fm2js_fuzzer_src",
]
dict = "dicts/pdf_codec_png.dict"
seed_corpuses = [
"corpora/pdf_codec_png",
"//components/viz/test/data",
"//third_party/blink/web_tests/images/png-suite/samples",
"//third_party/blink/web_tests/images/resources/pngfuzz",
] ]
dict = "dicts/pdf_formcalc.dict"
} }
}
if (pdf_enable_xfa_tiff) { fuzzer_test("pdf_formcalc_fuzzer") {
fuzzer_test("pdf_codec_tiff_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdf_codec_tiff_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdf_formcalc_fuzzer_src",
] ]
dict = "dicts/pdf_codec_tiff.dict" dict = "dicts/pdf_formcalc.dict"
seed_corpus = "corpora/pdf_codec_tiff"
} }
}
fuzzer_test("pdf_css_fuzzer") { if (pdf_enable_xfa_gif) {
sources = [] fuzzer_test("pdf_lzw_fuzzer") {
deps = [ sources = []
"//third_party/pdfium/testing/fuzzers:pdf_css_fuzzer_src", deps = [
] "//third_party/pdfium/testing/fuzzers:pdf_lzw_fuzzer_src",
dict = "dicts/pdf_css.dict" ]
} }
}
fuzzer_test("pdf_fm2js_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_fm2js_fuzzer_src",
]
dict = "dicts/pdf_formcalc.dict"
}
fuzzer_test("pdf_formcalc_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_formcalc_fuzzer_src",
]
dict = "dicts/pdf_formcalc.dict"
}
if (pdf_enable_xfa_gif) { fuzzer_test("pdf_bidi_fuzzer") {
fuzzer_test("pdf_lzw_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdf_lzw_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdf_bidi_fuzzer_src",
] ]
} }
}
fuzzer_test("pdf_bidi_fuzzer") { fuzzer_test("pdf_cfx_barcode_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdf_bidi_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdf_cfx_barcode_fuzzer_src",
] ]
} }
fuzzer_test("pdf_cfx_barcode_fuzzer") {
sources = []
deps = [
"//third_party/pdfium/testing/fuzzers:pdf_cfx_barcode_fuzzer_src",
]
}
fuzzer_test("pdfium_xfa_fuzzer") { fuzzer_test("pdfium_xfa_fuzzer") {
sources = [] sources = []
deps = [ deps = [
"//third_party/pdfium/testing/fuzzers:pdfium_xfa_fuzzer_src", "//third_party/pdfium/testing/fuzzers:pdfium_xfa_fuzzer_src",
] ]
dict = "dicts/pdf.dict" dict = "dicts/pdf.dict"
seed_corpus = "//third_party/pdfium/testing/resources" seed_corpus = "//third_party/pdfium/testing/resources"
}
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment