Fix gn check issues in chrome/credential_provider

This CL fixes most of the gn check issues in chrome/credential_provider
by adding necessary deps and removing some unused includes. This CL
enables gn check for the directories that are completely fixed. The
last issue will be fixed in a followup CL since it's more complex.

Bug: 1106758
Change-Id: Ib382eb7b3af808db00d806ffd46d8d9c76ecb280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304172
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789640}

.gn

@@ -74,9 +74,7 @@ no_check_targets = [
   "//chrome/browser/updates:*",  # 21 errors
   "//chrome/browser:*",  # 780 errors
   "//chrome/child:*",  # 3 errors
-  "//chrome/credential_provider/gaiacp:*",  # 34 errors
-  "//chrome/credential_provider/setup:*",  # 1 error
-  "//chrome/credential_provider/test:*",  # 22 errors
+  "//chrome/credential_provider/gaiacp:*",  # 1 error
   "//chrome/gpu:*",  # 2 errors
   "//chrome/install_static:*",  # 4 errors
   "//chrome/notification_helper:*",  # 4 errors

chrome/credential_provider/gaiacp/BUILD.gn

@@ -41,10 +41,12 @@ source_set("common") {
     "//build:branding_buildflags",
     "//chrome/common:version_header",
     "//chrome/installer/launcher_support",
+    "//components/crash/core/app",
     "//components/crash/core/common",
     "//components/version_info",
     "//google_apis:google_apis",
     "//third_party/re2",
+    "//url",
   ]
 }
 
@@ -117,6 +119,7 @@ source_set("gaiacp_lib") {
   deps = [
     ":gaia_credential_provider_idl",
     ":static_resources",
+    ":string_resources",
     "../eventlog:gcp_eventlog_messages",
     "//build:branding_buildflags",
     "//chrome/common:non_code_constants",
@@ -126,14 +129,14 @@ source_set("gaiacp_lib") {
     "//components/crash/core/app:app",
     "//components/crash/core/app:crash_export_thunks",
     "//components/crash/core/app:run_as_crashpad_handler",
+    "//content/public/browser",
+    "//crypto",
+    "//google_apis",
+    "//net",
     "//third_party/boringssl",
     "//third_party/re2",
+    "//url",
   ]
-  if (is_component_build) {
-    deps += [ "//content/public/common" ]
-  } else {
-    deps += [ "//content/public/common:static_switches" ]
-  }
   libs = [
     "hid.lib",
     "setupapi.lib",
@@ -228,8 +231,12 @@ shared_library("gaia1_0") {
     ":common",
     ":gaiacp_lib",
     ":version",
+    "//base",
     "//build:branding_buildflags",
     "//chrome/common:version_header",
+    "//components/crash/core/app",
+    "//components/crash/core/app:run_as_crashpad_handler",
+    "//content/public/browser",
   ]
   configs += [ "//build/config/win:windowed" ]
 }

chrome/credential_provider/gaiacp/gaia_credential.cc

@@ -13,7 +13,6 @@
 #include "chrome/credential_provider/gaiacp/logging.h"
 #include "chrome/credential_provider/gaiacp/mdm_utils.h"
 #include "content/public/common/content_switches.h"
-#include "google_apis/gaia/gaia_switches.h"
 
 namespace credential_provider {
 CGaiaCredential::CGaiaCredential() = default;

chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/credential_provider/gaiacp/dllmain.h"
+#include "chrome/credential_provider/gaiacp/gaia_credential_provider_module.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"

chrome/credential_provider/gaiacp/gcp_utils.h

@@ -5,6 +5,7 @@
 #ifndef CHROME_CREDENTIAL_PROVIDER_GAIACP_GCP_UTILS_H_
 #define CHROME_CREDENTIAL_PROVIDER_GAIACP_GCP_UTILS_H_
 
+#include <windows.h>
 #include <memory>
 #include <string>
 
@@ -15,7 +16,6 @@
 #include "base/version.h"
 #include "base/win/scoped_handle.h"
 #include "base/win/windows_types.h"
-#include "chrome/credential_provider/gaiacp/scoped_handle.h"
 #include "chrome/credential_provider/gaiacp/scoped_lsa_policy.h"
 #include "url/gurl.h"
 

chrome/credential_provider/gaiacp/gem_device_details_manager.cc

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 #include "chrome/credential_provider/gaiacp/gem_device_details_manager.h"
-#include "chrome/credential_provider/gaiacp/mdm_utils.h"
 
 #include <windows.h>
 #include <winternl.h>
@@ -23,6 +22,7 @@
 #include "chrome/credential_provider/gaiacp/gcpw_strings.h"
 #include "chrome/credential_provider/gaiacp/logging.h"
 #include "chrome/credential_provider/gaiacp/mdm_utils.h"
+#include "chrome/credential_provider/gaiacp/os_user_manager.h"
 #include "chrome/credential_provider/gaiacp/reg_utils.h"
 #include "chrome/credential_provider/gaiacp/win_http_url_fetcher.h"
 

chrome/credential_provider/gaiacp/mdm_utils.h

@@ -10,7 +10,6 @@
 #include "base/strings/string16.h"
 #include "base/values.h"
 #include "base/win/windows_types.h"
-#include "chrome/credential_provider/gaiacp/os_user_manager.h"
 #include "url/gurl.h"
 
 namespace credential_provider {

chrome/credential_provider/gaiacp/os_process_manager.cc

@@ -40,6 +40,7 @@
 #include "chrome/credential_provider/common/gcp_strings.h"
 #include "chrome/credential_provider/gaiacp/gcp_utils.h"
 #include "chrome/credential_provider/gaiacp/logging.h"
+#include "chrome/credential_provider/gaiacp/scoped_handle.h"
 
 typedef NTSTATUS(FAR WINAPI* NtOpenDirectoryObjectPfn)(
     OUT PHANDLE DirectoryHandle,

chrome/credential_provider/setup/gcp_installer_crash_reporting.cc

@@ -13,7 +13,6 @@
 #include "base/version.h"
 #include "base/win/registry.h"
 #include "build/branding_buildflags.h"
-#include "chrome/common/chrome_paths.h"
 #include "chrome/credential_provider/common/gcp_strings.h"
 #include "chrome/credential_provider/gaiacp/gcp_crash_reporter_client.h"
 #include "chrome/credential_provider/gaiacp/gcp_crash_reporting_utils.h"

chrome/credential_provider/test/BUILD.gn

@@ -30,11 +30,16 @@ test("gcp_unittests") {
 
   deps = [
     "../gaiacp:common",
+    "../gaiacp:gaia_credential_provider_idl",
     "../gaiacp:gaiacp_lib",
+    "../gaiacp:string_resources",
     "../gaiacp:version",
     "../setup:common",
     "//base",
+    "//chrome/common:non_code_constants",
     "//chrome/test:credential_provider_test_utils",
+    "//content/public/browser",
+    "//google_apis",
     "//net:test_support",
     "//testing/gmock",
     "//testing/gtest",