Commit bef3962e authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

Revert "[iOS] Add Overrides provider"

This reverts commit e7684fe6.

Reason for revert: Break the tests

Original change's description:
> [iOS] Add Overrides provider
> 
> The provider is used to install overrides.
> 
> Bug: 954570
> Change-Id: I89acf24af55f3e657db9f421dec8330abac1e64b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584265
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#654815}

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,gambard@chromium.org

Change-Id: Ia22048bb36549154f8201072be00665ad04c097f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 954570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587600Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654820}
parent a36c7b1d
...@@ -152,7 +152,6 @@ ...@@ -152,7 +152,6 @@
#include "ios/public/provider/chrome/browser/chrome_browser_provider.h" #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
#include "ios/public/provider/chrome/browser/distribution/app_distribution_provider.h" #include "ios/public/provider/chrome/browser/distribution/app_distribution_provider.h"
#include "ios/public/provider/chrome/browser/mailto/mailto_handler_provider.h" #include "ios/public/provider/chrome/browser/mailto/mailto_handler_provider.h"
#import "ios/public/provider/chrome/browser/overrides_provider.h"
#include "ios/public/provider/chrome/browser/signin/chrome_identity_service.h" #include "ios/public/provider/chrome/browser/signin/chrome_identity_service.h"
#import "ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h" #import "ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h"
#import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h" #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
...@@ -794,8 +793,6 @@ enum class EnterTabSwitcherSnapshotResult { ...@@ -794,8 +793,6 @@ enum class EnterTabSwitcherSnapshotResult {
notifyForeground:_mainBrowserState]; notifyForeground:_mainBrowserState];
} }
ios::GetChromeBrowserProvider()->GetOverridesProvider()->InstallOverrides();
[self scheduleLowPriorityStartupTasks]; [self scheduleLowPriorityStartupTasks];
[_browserViewWrangler updateDeviceSharingManager]; [_browserViewWrangler updateDeviceSharingManager];
......
...@@ -13,8 +13,6 @@ source_set("browser") { ...@@ -13,8 +13,6 @@ source_set("browser") {
"chrome_browser_provider.mm", "chrome_browser_provider.mm",
"geolocation_updater_provider.h", "geolocation_updater_provider.h",
"geolocation_updater_provider.mm", "geolocation_updater_provider.mm",
"overrides_provider.h",
"overrides_provider.mm",
] ]
deps = [ deps = [
"//base", "//base",
......
...@@ -22,7 +22,6 @@ class BrowserURLRewriterProvider; ...@@ -22,7 +22,6 @@ class BrowserURLRewriterProvider;
class FullscreenProvider; class FullscreenProvider;
class MailtoHandlerProvider; class MailtoHandlerProvider;
class OmahaServiceProvider; class OmahaServiceProvider;
class OverridesProvider;
class SpecialUserProvider; class SpecialUserProvider;
class SpotlightProvider; class SpotlightProvider;
class UserFeedbackProvider; class UserFeedbackProvider;
...@@ -164,9 +163,6 @@ class ChromeBrowserProvider { ...@@ -164,9 +163,6 @@ class ChromeBrowserProvider {
// Returns an instance of the BrowserURLRewriter provider. // Returns an instance of the BrowserURLRewriter provider.
virtual BrowserURLRewriterProvider* GetBrowserURLRewriterProvider() const; virtual BrowserURLRewriterProvider* GetBrowserURLRewriterProvider() const;
// Returns an instance of the Overrides provider;
virtual OverridesProvider* GetOverridesProvider() const;
// Adds and removes observers. // Adds and removes observers.
void AddObserver(Observer* observer); void AddObserver(Observer* observer);
void RemoveObserver(Observer* observer); void RemoveObserver(Observer* observer);
......
...@@ -118,10 +118,6 @@ ChromeBrowserProvider::GetBrowserURLRewriterProvider() const { ...@@ -118,10 +118,6 @@ ChromeBrowserProvider::GetBrowserURLRewriterProvider() const {
return nullptr; return nullptr;
} }
OverridesProvider* ChromeBrowserProvider::GetOverridesProvider() const {
return nullptr;
}
MailtoHandlerProvider* ChromeBrowserProvider::GetMailtoHandlerProvider() const { MailtoHandlerProvider* ChromeBrowserProvider::GetMailtoHandlerProvider() const {
return mailto_handler_provider_.get(); return mailto_handler_provider_.get();
} }
......
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_OVERRIDES_PROVIDER_H_
#define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_OVERRIDES_PROVIDER_H_
// Provider for installing overrides.
class OverridesProvider {
public:
OverridesProvider();
virtual ~OverridesProvider();
virtual void InstallOverrides();
};
#endif // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_OVERRIDES_PROVIDER_H_
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "ios/public/provider/chrome/browser/overrides_provider.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif
OverridesProvider::OverridesProvider() = default;
OverridesProvider::~OverridesProvider() = default;
void OverridesProvider::InstallOverrides() {}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment