Commit bf0867c3 authored by kylechar's avatar kylechar Committed by Commit Bot

viz: Add comment explaining GetFrameSinkManager().

VizProcessTransportFactory::GetFrameSinkManager() has a NOTREACHED()
that is intentional. This is likely to be where other teams see crashes
originating from in viz_content_browsertests, so add a better comment to
give some context for why it's happening.

Bug: none
Change-Id: Ib4eb4ff9d71a86d04359d6d20a30f6c819e49126
Reviewed-on: https://chromium-review.googlesource.com/824985Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523979}
parent d181a1ae
...@@ -305,7 +305,11 @@ void VizProcessTransportFactory::SetOutputIsSecure(ui::Compositor* compositor, ...@@ -305,7 +305,11 @@ void VizProcessTransportFactory::SetOutputIsSecure(ui::Compositor* compositor,
} }
viz::FrameSinkManagerImpl* VizProcessTransportFactory::GetFrameSinkManager() { viz::FrameSinkManagerImpl* VizProcessTransportFactory::GetFrameSinkManager() {
// FrameSinkManagerImpl is in the gpu process, not the browser process. // When running with viz there is no FrameSinkManagerImpl in the browser
// process. FrameSinkManagerImpl runs in the GPU process instead. Anything in
// the browser process that relies FrameSinkManagerImpl or SurfaceManager
// internal state needs to change. See https://crbug.com/787097 and
// https://crbug.com/760181 for more context.
NOTREACHED(); NOTREACHED();
return nullptr; return nullptr;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment