Commit bf1d41bb authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot

About WebUI: a11y, use cr-link-row so row is treated as one button

Bug: 870460
Change-Id: I24fa99baa9e390df94be3e6f01bf2a3127bfc37c
Reviewed-on: https://chromium-review.googlesource.com/c/1311773
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604734}
parent 518fa55c
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
<link rel="import" href="../settings_page_css.html"> <link rel="import" href="../settings_page_css.html">
<link rel="import" href="../settings_shared_css.html"> <link rel="import" href="../settings_shared_css.html">
<link rel="import" href="../settings_vars_css.html"> <link rel="import" href="../settings_vars_css.html">
<link rel="import" href="chrome://resources/cr_elements/cr_link_row/cr_link_row.html">
<link rel="import" href="chrome://resources/cr_elements/icons.html"> <link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html"> <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
<link rel="import" href="chrome://resources/html/assert.html"> <link rel="import" href="chrome://resources/html/assert.html">
...@@ -239,32 +240,19 @@ ...@@ -239,32 +240,19 @@
</div> </div>
</template> </template>
</if> </if>
<div id="help" class="settings-box" on-click="onHelpTap_" <cr-link-row class="hr" icon-class="icon-external" id="help"
actionable> on-click="onHelpTap_" label="$i18n{aboutGetHelpUsingChrome}">
<div class="start">$i18n{aboutGetHelpUsingChrome}</div> </cr-link-row>
<paper-icon-button-light class="icon-external">
<button aria-labelledby="help"></button>
</paper-icon-button-light>
</div>
<if expr="_google_chrome"> <if expr="_google_chrome">
<div id="reportIssue" class="settings-box" actionable <cr-link-row class="hr" icon-class="subpage-arrow" id="reportIssue"
on-click="onReportIssueTap_"> on-click="onReportIssueTap_" label="$i18n{aboutReportAnIssue}">
<div class="start">$i18n{aboutReportAnIssue}</div> </cr-link-row>
<paper-icon-button-light class="subpage-arrow">
<button aria-labelledby="reportIssue"></button>
</paper-icon-button-light>
</div>
</if> </if>
<if expr="chromeos"> <if expr="chromeos">
<div class="settings-box" on-click="onDetailedBuildInfoTap_" <cr-link-row class="hr" icon-class="subpage-arrow"
actionable> id="detailed-build-info-trigger"
<div class="start">$i18n{aboutDetailedBuildInfo}</div> on-click="onDetailedBuildInfoTap_"
<paper-icon-button-light class="subpage-arrow"> label="$i18n{aboutDetailedBuildInfo}"></cr-link-row>
<button id="detailed-build-info-trigger"
aria-label="$i18n{aboutDetailedBuildInfo}">
</button>
</paper-icon-button-light>
</div>
</if> </if>
</neon-animatable> </neon-animatable>
<if expr="chromeos"> <if expr="chromeos">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment