Commit bf2d1570 authored by Amy Qiu's avatar Amy Qiu Committed by Commit Bot

Remove unnecessary attribute from top_real_world_mobile

Since the 'action_on_load_complete' attribute is only used by one child
class, move it out of the parent class.

Bug: 760553
Change-Id: I364794926e8d6b342e5b22402cefd6893dd3b5a2
Reviewed-on: https://chromium-review.googlesource.com/1076976Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#562601}
parent bf822f7d
...@@ -25,9 +25,6 @@ class TopRealWorldMobilePage(rendering_story.RenderingStory): ...@@ -25,9 +25,6 @@ class TopRealWorldMobilePage(rendering_story.RenderingStory):
shared_page_state_class=shared_page_state_class) shared_page_state_class=shared_page_state_class)
def RunPageInteractions(self, action_runner): def RunPageInteractions(self, action_runner):
if self.action_on_load_complete:
action_runner.WaitForJavaScriptCondition(
'document.readyState == "complete"', timeout=30)
with action_runner.CreateGestureInteraction('ScrollAction'): with action_runner.CreateGestureInteraction('ScrollAction'):
action_runner.ScrollPage() action_runner.ScrollPage()
...@@ -296,7 +293,12 @@ class WikipediaDelayedScrollMobilePage(TopRealWorldMobilePage): ...@@ -296,7 +293,12 @@ class WikipediaDelayedScrollMobilePage(TopRealWorldMobilePage):
name_suffix=name_suffix, name_suffix=name_suffix,
extra_browser_args=extra_browser_args, extra_browser_args=extra_browser_args,
shared_page_state_class=shared_page_state_class) shared_page_state_class=shared_page_state_class)
self.action_on_load_complete = True
def RunPageInteractions(self, action_runner):
action_runner.WaitForJavaScriptCondition(
'document.readyState == "complete"', timeout=30)
with action_runner.CreateGestureInteraction('ScrollAction'):
action_runner.ScrollPage()
class BlogspotMobilePage(TopRealWorldMobilePage): class BlogspotMobilePage(TopRealWorldMobilePage):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment