Commit bf330448 authored by erikchen's avatar erikchen Committed by Commit bot

Mac: Revert "Make logic for disabling OS crash catcher on OSX match comment."

This CL breaks chrome://inducebrowsercrashforrealz

I don't know exactly why the behavior is broken, but it appears that setting a
signal handler for SIGTRAP interferes with breakpad exception handling. See bug
for more details.

Original CL: https://codereview.chromium.org/329423003
Original Commit: d81d222c

TBR=cpu@chromium.org
BUG=402337

Review URL: https://codereview.chromium.org/602793002

Cr-Commit-Position: refs/heads/master@{#296530}
parent 511a8be6
......@@ -568,10 +568,12 @@ void ChromeMainDelegate::InitMacCrashReporter(
// itself.
// * If Breakpad is disabled, we only turn on Crash Reporter for the
// Browser process in release mode.
if (base::mac::IsBackgroundOnlyProcess() ||
breakpad::IsCrashReporterEnabled() ||
is_debug_build) {
base::mac::DisableOSCrashDumps();
if (!command_line.HasSwitch(switches::kDisableBreakpad)) {
bool disable_apple_crash_reporter = is_debug_build ||
base::mac::IsBackgroundOnlyProcess();
if (!breakpad::IsCrashReporterEnabled() && disable_apple_crash_reporter) {
base::mac::DisableOSCrashDumps();
}
}
// Mac Chrome is packaged with a main app bundle and a helper app bundle.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment