Commit bf707788 authored by mgiuca's avatar mgiuca Committed by Commit bot

StartPageService: Use a StringPiece instead of modifying a string.

This is possible now that JSONStringValueSerializer takes a StringPiece.

BUG=455068

Review URL: https://codereview.chromium.org/891473004

Cr-Commit-Position: refs/heads/master@{#314770}
parent 8bf25811
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "base/memory/singleton.h" #include "base/memory/singleton.h"
#include "base/metrics/user_metrics.h" #include "base/metrics/user_metrics.h"
#include "base/prefs/pref_service.h" #include "base/prefs/pref_service.h"
#include "base/strings/string_piece.h"
#include "chrome/browser/browser_process.h" #include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/media/media_stream_infobar_delegate.h" #include "chrome/browser/media/media_stream_infobar_delegate.h"
...@@ -579,10 +580,11 @@ void StartPageService::OnURLFetchComplete(const net::URLFetcher* source) { ...@@ -579,10 +580,11 @@ void StartPageService::OnURLFetchComplete(const net::URLFetcher* source) {
// Remove XSSI guard for JSON parsing. // Remove XSSI guard for JSON parsing.
size_t json_start_index = json_data.find("{"); size_t json_start_index = json_data.find("{");
base::StringPiece json_data_substr(json_data);
if (json_start_index != std::string::npos) if (json_start_index != std::string::npos)
json_data.erase(0, json_start_index); json_data_substr.remove_prefix(json_start_index);
JSONStringValueSerializer deserializer(json_data); JSONStringValueSerializer deserializer(json_data_substr);
deserializer.set_allow_trailing_comma(true); deserializer.set_allow_trailing_comma(true);
int error_code = 0; int error_code = 0;
scoped_ptr<base::Value> doodle_json( scoped_ptr<base::Value> doodle_json(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment