Commit bf75e280 authored by Pavel Yatsuk's avatar Pavel Yatsuk Committed by Commit Bot

[Modularization] Make InfoBarIdentifier referrable from multiple places outside chrome/android

Currently InfoBarIdentifier class generated from enum in
infobar_delegate.h is only available as a source file to be included
through srcjar_deps. This makes it impossible to refer to it from both
chrome/android and chrome/browser.

This CL adds an android_library target for the generated file, allowing
it to be referred from multiple targets through deps.

BUG=1056346
R=pkasting@chromium.org,twellington@chromium.org

Change-Id: I054fb864c7503006e6aa8bf3fc0aedc22d3c8d7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079833Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745439}
parent 3a81544a
...@@ -305,6 +305,7 @@ android_library("chrome_java") { ...@@ -305,6 +305,7 @@ android_library("chrome_java") {
"//components/find_in_page/android:java", "//components/find_in_page/android:java",
"//components/gcm_driver/android:gcm_driver_java", "//components/gcm_driver/android:gcm_driver_java",
"//components/gcm_driver/instance_id/android:instance_id_driver_java", "//components/gcm_driver/instance_id/android:instance_id_driver_java",
"//components/infobars/core:infobar_enums_java",
"//components/javascript_dialogs/android:java", "//components/javascript_dialogs/android:java",
"//components/language/android:language_bridge_java", "//components/language/android:language_bridge_java",
"//components/location/android:location_java", "//components/location/android:location_java",
...@@ -432,7 +433,6 @@ android_library("chrome_java") { ...@@ -432,7 +433,6 @@ android_library("chrome_java") {
"//components/data_reduction_proxy/core/browser:data_reduction_proxy_savings_cleared_enum_java", "//components/data_reduction_proxy/core/browser:data_reduction_proxy_savings_cleared_enum_java",
"//components/dom_distiller/core:distiller_type_java", "//components/dom_distiller/core:distiller_type_java",
"//components/favicon_base:favicon_base_enums_java", "//components/favicon_base:favicon_base_enums_java",
"//components/infobars/core:infobar_enums_java",
"//components/ntp_snippets:ntp_snippets_java_enums_srcjar", "//components/ntp_snippets:ntp_snippets_java_enums_srcjar",
"//components/ntp_tiles:ntp_tiles_enums_java", "//components/ntp_tiles:ntp_tiles_enums_java",
"//components/offline_pages/core:offline_page_model_enums_java", "//components/offline_pages/core:offline_page_model_enums_java",
......
...@@ -72,6 +72,7 @@ android_library("java") { ...@@ -72,6 +72,7 @@ android_library("java") {
"//chrome/browser/util:java", "//chrome/browser/util:java",
"//components/browser_ui/modaldialog/android:java", "//components/browser_ui/modaldialog/android:java",
"//components/embedder_support/android:content_view_java", "//components/embedder_support/android:content_view_java",
"//components/infobars/core:infobar_enums_java",
"//components/policy/android:policy_java", "//components/policy/android:policy_java",
"//content/public/android:content_java", "//content/public/android:content_java",
"//device/vr:java", "//device/vr:java",
......
...@@ -54,7 +54,13 @@ source_set("feature_flags") { ...@@ -54,7 +54,13 @@ source_set("feature_flags") {
} }
if (is_android) { if (is_android) {
java_cpp_enum("infobar_enums_java") { java_cpp_enum("infobar_generated_enums") {
sources = [ "infobar_delegate.h" ] sources = [ "infobar_delegate.h" ]
} }
android_library("infobar_enums_java") {
deps = [ "//third_party/android_deps:androidx_annotation_annotation_java" ]
srcjar_deps = [ ":infobar_generated_enums" ]
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment