Extensions WebUI: Remove testIcons() defunct test method.

This method is using /deep/ which only worked in Shadow DOM v0. Extensions has
been using SDv1 since M72, and this test is silently doing nothing (does not
find any iron-icons to assert on).

Fixed: 885401
Change-Id: I1ba5836bb0109337e1439f30453094d65089e822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864018Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708461}

chrome/test/data/webui/extensions/detail_view_test.js

@@ -52,8 +52,6 @@ cr.define('extension_detail_view_tests', function() {
     test(assert(TestNames.Layout), function() {
       Polymer.dom.flush();
 
-      extension_test_util.testIcons(item);
-
       const testIsVisible = test_util.isVisible.bind(null, item);
       expectTrue(testIsVisible('#closeButton'));
       expectTrue(testIsVisible('#icon'));

chrome/test/data/webui/extensions/error_page_test.js

@@ -85,8 +85,6 @@ cr.define('extension_error_page_tests', function() {
     test(assert(TestNames.Layout), function() {
       Polymer.dom.flush();
 
-      extension_test_util.testIcons(errorPage);
-
       const testIsVisible = test_util.isVisible.bind(null, errorPage);
       expectTrue(testIsVisible('#closeButton'));
       expectTrue(testIsVisible('#heading'));

chrome/test/data/webui/extensions/item_test.js

@@ -287,26 +287,22 @@ cr.define('extension_item_tests', function() {
       const icon = item.$$('#source-indicator iron-icon');
       assertTrue(!!icon);
       expectEquals('extensions-icons:unpacked', icon.icon);
-      extension_test_util.testIcons(item);
 
       item.set('data.location', 'THIRD_PARTY');
       Polymer.dom.flush();
       expectTrue(test_util.isVisible(item, '#source-indicator'));
       expectEquals('extensions-icons:input', icon.icon);
-      extension_test_util.testIcons(item);
 
       item.set('data.location', 'UNKNOWN');
       Polymer.dom.flush();
       expectTrue(test_util.isVisible(item, '#source-indicator'));
       expectEquals('extensions-icons:input', icon.icon);
-      extension_test_util.testIcons(item);
 
       item.set('data.location', 'FROM_STORE');
       item.set('data.controlledInfo', {type: 'POLICY', text: 'policy'});
       Polymer.dom.flush();
       expectTrue(test_util.isVisible(item, '#source-indicator'));
       expectEquals('extensions-icons:business', icon.icon);
-      extension_test_util.testIcons(item);
 
       item.set('data.controlledInfo', null);
       Polymer.dom.flush();

chrome/test/data/webui/extensions/sidebar_test.js

@@ -52,8 +52,6 @@ cr.define('extension_sidebar_tests', function() {
     });
 
     test(assert(TestNames.LayoutAndClickHandlers), function(done) {
-      extension_test_util.testIcons(sidebar);
-
       const testVisible = extension_test_util.testVisible.bind(null, sidebar);
       testVisible('#sections-extensions', true);
       testVisible('#sections-shortcuts', true);

chrome/test/data/webui/extensions/test_util.js

@@ -207,22 +207,6 @@ cr.define('extension_test_util', function() {
         opt_properties);
   }
 
-  /**
-   * Tests that any visible iron-icon child of an HTML element has a
-   * corresponding non-empty svg element.
-   * @param {HTMLElement} e The element to check the iron icons in.
-   */
-  function testIcons(e) {
-    e.querySelectorAll('* /deep/ iron-icon').forEach(function(icon) {
-      if (isElementVisible(icon)) {
-        const svg = icon.$$('svg');
-        expectTrue(
-            !!svg && svg.innerHTML != '',
-            'icon "' + icon.icon + '" is not present');
-      }
-    });
-  }
-
   /**
    * Finds all nodes matching |query| under |root|, within self and children's
    * Shadow DOM.
@@ -261,7 +245,6 @@ cr.define('extension_test_util', function() {
     isElementVisible: isElementVisible,
     testVisible: testVisible,
     createExtensionInfo: createExtensionInfo,
-    testIcons: testIcons,
     findMatches: findMatches,
   };
 });

chrome/test/data/webui/extensions/toolbar_test.js

@@ -28,8 +28,6 @@ cr.define('extension_toolbar_tests', function() {
     });
 
     test(assert(TestNames.Layout), function() {
-      extension_test_util.testIcons(toolbar);
-
       const testVisible = extension_test_util.testVisible.bind(null, toolbar);
       testVisible('#devMode', true);
       assertEquals(toolbar.$.devMode.disabled, false);