Commit bf8816b2 authored by vabr@chromium.org's avatar vabr@chromium.org

Password manager: Enabling Public Suffix List matching on Windows.

The PSL matching seems to work already on Windows, because it only depends on the platform-independent parts of login_database.cc.

After manually verifying that it works (with a Release ToT build), I'd like to enable it on trunk in this CL.

I will make sure that this change does not propagate to beta and stable before it passes all the reviews in the launch bug (linked from the BUG below).

BUG=324291

Review URL: https://codereview.chromium.org/131683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244172 0039d316-1c4b-4281-b951-d872f2087c98
parent 52f7bf2c
...@@ -1287,7 +1287,7 @@ const Experiment kExperiments[] = { ...@@ -1287,7 +1287,7 @@ const Experiment kExperiments[] = {
"password-autofill-public-suffix-domain-matching", "password-autofill-public-suffix-domain-matching",
IDS_FLAGS_PASSWORD_AUTOFILL_PUBLIC_SUFFIX_DOMAIN_MATCHING_NAME, IDS_FLAGS_PASSWORD_AUTOFILL_PUBLIC_SUFFIX_DOMAIN_MATCHING_NAME,
IDS_FLAGS_PASSWORD_AUTOFILL_PUBLIC_SUFFIX_DOMAIN_MATCHING_DESCRIPTION, IDS_FLAGS_PASSWORD_AUTOFILL_PUBLIC_SUFFIX_DOMAIN_MATCHING_DESCRIPTION,
kOsAndroid, kOsAndroid | kOsWin,
ENABLE_DISABLE_VALUE_TYPE( ENABLE_DISABLE_VALUE_TYPE(
switches::kEnablePasswordAutofillPublicSuffixDomainMatching, switches::kEnablePasswordAutofillPublicSuffixDomainMatching,
switches::kDisablePasswordAutofillPublicSuffixDomainMatching) switches::kDisablePasswordAutofillPublicSuffixDomainMatching)
......
...@@ -55,7 +55,7 @@ void PSLMatchingHelper::EnablePublicSuffixDomainMatchingForTesting() { ...@@ -55,7 +55,7 @@ void PSLMatchingHelper::EnablePublicSuffixDomainMatchingForTesting() {
// static // static
bool PSLMatchingHelper::DeterminePSLEnabled() { bool PSLMatchingHelper::DeterminePSLEnabled() {
#if defined(OS_ANDROID) #if defined(OS_ANDROID) || defined(OS_WIN)
// Default choice is "enabled", so we do not need to check for // Default choice is "enabled", so we do not need to check for
// kEnablePasswordAutofillPublicSuffixDomainMatching. // kEnablePasswordAutofillPublicSuffixDomainMatching.
bool enabled = true; bool enabled = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment