Commit bf9eca7c authored by Timothy Gu's avatar Timothy Gu Committed by Commit Bot

Origin policy: Use a const reference where appropriate

This addresses a follow-up to 15c60c50.

Fixed: 1061139
Change-Id: Icf29c63041d5ab54be4f3a545e6835fe535acbb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114584
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: default avatarDomenic Denicola <domenic@chromium.org>
Reviewed-by: default avatarDaniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754488}
parent a15a990f
......@@ -32,19 +32,17 @@ base::Optional<OriginPolicyParsedHeader> OriginPolicyParsedHeader::FromString(
return base::nullopt;
}
// TODO(domenic): when https://crbug.com/1061139 gets fixed we can
// make this a const reference.
sh::Dictionary& parsed_header = *parsed_header_opt;
const sh::Dictionary& parsed_header = *parsed_header_opt;
std::vector<OriginPolicyAllowedValue> allowed;
if (parsed_header.contains("allowed")) {
if (!parsed_header["allowed"].member_is_inner_list) {
if (!parsed_header.at("allowed").member_is_inner_list) {
return base::nullopt;
}
const std::vector<sh::ParameterizedItem>& raw_allowed_list =
parsed_header["allowed"].member;
parsed_header.at("allowed").member;
for (const auto& parameterized_item : raw_allowed_list) {
base::Optional<OriginPolicyAllowedValue> result;
......@@ -74,11 +72,11 @@ base::Optional<OriginPolicyParsedHeader> OriginPolicyParsedHeader::FromString(
base::Optional<OriginPolicyPreferredValue> preferred;
if (parsed_header.contains("preferred")) {
if (parsed_header["preferred"].member_is_inner_list) {
if (parsed_header.at("preferred").member_is_inner_list) {
return base::nullopt;
}
const sh::Item& item = parsed_header["preferred"].member[0].item;
const sh::Item& item = parsed_header.at("preferred").member[0].item;
if (item.is_string()) {
const std::string& string = item.GetString();
if (string.empty()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment