Allow chrome_shell_paks target to be reused

Currently, when multiple downstream targets depend on chrome_shell resource
paks, ninja outputs several warnings similar to:

ninja: warning: multiple rules generate ../assets/sample_apk/am.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate ../assets/sample_apk/ar.pak. builds involving this target will not be correct; continuing anyway

This commit refactors the pak copying logic into chrome_android_paks.gypi to
allow proper reuse of the target.

BUG=441011

Review URL: https://codereview.chromium.org/793943004

Cr-Commit-Position: refs/heads/master@{#312960}

chrome/chrome_android_paks.gypi

@@ -121,5 +121,23 @@
       }],
     ],
   },
+  'targets': [
+    {
+      'target_name': 'chrome_android_paks_copy',
+      'type': 'none',
+      'dependencies': [
+        '<(DEPTH)/chrome/chrome_resources.gyp:packed_resources',
+        '<(DEPTH)/chrome/chrome_resources.gyp:packed_extra_resources',
+      ],
+      'copies': [
+        {
+          'destination': '<(chrome_android_pak_output_folder)',
+          'files': [
+            '<@(chrome_android_pak_input_resources)',
+          ],
+        }
+      ],
+    },
+  ],
 }
 

chrome/chrome_shell.gypi

@@ -95,7 +95,7 @@
       'type': 'none',
       'dependencies': [
         'chrome_java',
-        'chrome_shell_paks',
+        'chrome_android_paks_copy',
         'libchromeshell',
         '../media/media.gyp:media_java',
       ],
@@ -128,22 +128,6 @@
       ],
       'includes': [ '../build/apk_fake_jar.gypi' ],
     },
-    {
-      'target_name': 'chrome_shell_paks',
-      'type': 'none',
-      'dependencies': [
-        '<(DEPTH)/chrome/chrome_resources.gyp:packed_resources',
-        '<(DEPTH)/chrome/chrome_resources.gyp:packed_extra_resources',
-      ],
-      'copies': [
-        {
-          'destination': '<(chrome_android_pak_output_folder)',
-          'files': [
-            '<@(chrome_android_pak_input_resources)',
-          ],
-        }
-      ],
-    },
     {
       # GN: //chrome/android:chrome_sync_shell_manifest
       'target_name': 'chrome_sync_shell_manifest',
@@ -160,7 +144,7 @@
       'type': 'none',
       'dependencies': [
         'chrome_java',
-        'chrome_shell_paks',
+        'chrome_android_paks_copy',
         'libchromesyncshell',
         '../media/media.gyp:media_java',
         '../sync/sync.gyp:sync_java_test_support',