Commit bffdecc5 authored by Alexey Kozyatinskiy's avatar Alexey Kozyatinskiy Committed by Commit Bot

[DevTools] prepare tests for better async breakpoints locations

With V8 side CL [1] we will start using proper break location instead
of stack check location almost all the time, e.g. for async step-into
and for a lot of DOM breakpoints.

[1] https://chromium-review.googlesource.com/c/v8/v8/+/1054155

R=dgozman@chromium.org

Bug: v8:7753
Change-Id: I550d4d43494df7abe8c5fcd0fbb1d08ca88364f6
Reviewed-on: https://chromium-review.googlesource.com/1055791Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558138}
parent f4e69810
......@@ -2544,6 +2544,15 @@ crbug.com/591500 [ Win10 ] virtual/threaded/printing/quirks-percentage-height.ht
crbug.com/591500 [ Win10 ] virtual/threaded/printing/standards-percentage-heights.html [ Failure ]
crbug.com/591500 [ Win10 ] virtual/threaded/printing/subframes-percentage-height.html [ Failure ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-xhr.js [ Skip ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints.js [ Skip ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.js [ Skip ]
crbug.com/v8/7753 http/tests/devtools/sources/debugger-step/step-through-event-listeners.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/debugger/message-channel-async-stack.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/worker/worker-on-message-async-stacks.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/worker/worker-post-message-async-stacks.js [ Skip ]
# TODO(chrishtr) uncomment ones marked crbug.com/591500 after fixing crbug.com/665259.
crbug.com/591500 [ Win10 ] printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]
crbug.com/591500 [ Win10 ] virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]
......
......@@ -4,7 +4,7 @@ Tests event listener breakpoints.
Running: testClickBreakpoint
Script execution paused.
Call stack:
0) testElementEventListener (event-listener-breakpoints.js:14)
0) testElementEventListener (event-listener-breakpoints.js:16)
1) addListenerAndClick (event-listener-breakpoints.js:23)
2) (:1)
Event target: INPUT
......@@ -13,7 +13,7 @@ Script execution resumed.
Running: testAuxclickBreakpoint
Script execution paused.
Call stack:
0) testElementEventListener (event-listener-breakpoints.js:14)
0) testElementEventListener (event-listener-breakpoints.js:16)
1) addListenerAndAuxclick (event-listener-breakpoints.js:30)
2) (:1)
Event target: INPUT
......@@ -22,27 +22,27 @@ Script execution resumed.
Running: testTimerFiredBreakpoint
Script execution paused.
Call stack:
0) timerFired (event-listener-breakpoints.js:40)
0) timerFired (event-listener-breakpoints.js:42)
Script execution resumed.
Running: testLoadBreakpointOnXHR
Script execution paused.
Call stack:
0) loadCallback (event-listener-breakpoints.js:63)
0) loadCallback (event-listener-breakpoints.js:65)
Event target: XMLHttpRequest
Script execution resumed.
Running: testMediaEventBreakpoint
Script execution paused.
Call stack:
0) onVideoPlay (event-listener-breakpoints.js:75)
0) onVideoPlay (event-listener-breakpoints.js:77)
Event target: VIDEO
Script execution resumed.
Running: testPointerEventBreakpoint
Script execution paused.
Call stack:
0) testElementEventListener (event-listener-breakpoints.js:14)
0) testElementEventListener (event-listener-breakpoints.js:16)
1) addListenerAndPointerDown (event-listener-breakpoints.js:37)
2) (:1)
Event target: INPUT
......
......@@ -3,27 +3,27 @@ Tests event listener breakpoints on XHRs.
Set timer for test function.
Captured call stacks in no particular order:
Call stack:
0) downloadEnd (event-listener-breakpoints-xhr.js:22)
0) downloadEnd (event-listener-breakpoints-xhr.js:24)
Event target: XMLHttpRequest
Call stack:
0) downloadProgress (event-listener-breakpoints-xhr.js:30)
0) downloadProgress (event-listener-breakpoints-xhr.js:32)
Event target: XMLHttpRequest
Call stack:
0) loadCallback (event-listener-breakpoints-xhr.js:38)
0) loadCallback (event-listener-breakpoints-xhr.js:40)
Event target: XMLHttpRequest
Call stack:
0) uploadEnd (event-listener-breakpoints-xhr.js:26)
0) uploadEnd (event-listener-breakpoints-xhr.js:28)
Event target: XMLHttpRequestUpload
Call stack:
0) uploadProgress (event-listener-breakpoints-xhr.js:34)
0) uploadProgress (event-listener-breakpoints-xhr.js:36)
Event target: XMLHttpRequestUpload
Call stack:
0) xhr.onreadystatechange (event-listener-breakpoints-xhr.js:18)
0) xhr.onreadystatechange (event-listener-breakpoints-xhr.js:20)
1) sendXHR (event-listener-breakpoints-xhr.js:49)
2) testFunction (event-listener-breakpoints-xhr.js:12)
Event target: XMLHttpRequest
......
......@@ -21,7 +21,7 @@ Paused on XHR or fetchhttp://127.0.0.1:8000/devtools/sources/debugger-frameworks
Running: testEventListenerBreakpoint
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:32)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:34)
* 1) Framework_bound (framework.js:105)
* 2) Framework_eventListener (framework.js:86)
3) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:45)
......@@ -31,7 +31,7 @@ Call stack:
Executing Resume...
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:32)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:34)
* 1) Framework_bound (framework.js:105)
* 2) Framework_eventListener (framework.js:86)
3) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:51)
......@@ -60,7 +60,7 @@ Executing StepOver...
Executing StepOver...
Executing StepOver...
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:32)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:34)
* 1) Framework_bound (framework.js:105)
* 2) Framework_eventListener (framework.js:86)
3) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:45)
......@@ -74,7 +74,7 @@ Executing StepOver...
Executing StepOver...
Executing StepOver...
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:32)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:34)
* 1) Framework_bound (framework.js:105)
* 2) Framework_eventListener (framework.js:86)
3) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:51)
......@@ -86,7 +86,7 @@ Executing StepOver...
Executing StepOver...
Executing StepOver...
Call stack:
0) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:52)
0) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:53)
1) (:1)
[setTimeout]
0) (:1)
......@@ -96,7 +96,7 @@ Executing Resume...
Running: testSteppingOutOnEventListenerBreakpoint
Executing StepOut...
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:32)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:34)
* 1) Framework_bound (framework.js:105)
* 2) Framework_eventListener (framework.js:86)
3) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:45)
......@@ -107,7 +107,7 @@ Call stack:
Executing StepOut...
Executing StepOut...
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:32)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:34)
* 1) Framework_bound (framework.js:105)
* 2) Framework_eventListener (framework.js:86)
3) addListenerAndClick (frameworks-dom-xhr-event-breakpoints.js:51)
......@@ -127,7 +127,7 @@ Executing Resume...
Running: testSteppingOutOnEventListenerBreakpointAllBlackboxedButOne
Executing StepOut...
Call stack:
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:58)
0) testElementClicked (frameworks-dom-xhr-event-breakpoints.js:60)
* 1) Framework.safeRun (framework.js:8)
* 2) Framework.safeRun (framework.js:10)
* 3) Framework_bound (framework.js:105)
......
......@@ -4,25 +4,25 @@ Test that debugger will pause in all event listeners when corresponding breakpoi
Running: testClickBreakpoint
Script execution paused.
Call stack:
0) listener3 (step-through-event-listeners.js:22)
0) listener3 (step-through-event-listeners.js:24)
1) addListenerAndClick (step-through-event-listeners.js:33)
2) (:1)
Script execution resumed.
Script execution paused.
Call stack:
0) listener1 (step-through-event-listeners.js:14)
0) listener1 (step-through-event-listeners.js:16)
1) addListenerAndClick (step-through-event-listeners.js:33)
2) (:1)
Script execution resumed.
Script execution paused.
Call stack:
0) listener2 (step-through-event-listeners.js:18)
0) listener2 (step-through-event-listeners.js:20)
1) addListenerAndClick (step-through-event-listeners.js:33)
2) (:1)
Script execution resumed.
Script execution paused.
Call stack:
0) listener3 (step-through-event-listeners.js:22)
0) listener3 (step-through-event-listeners.js:24)
1) addListenerAndClick (step-through-event-listeners.js:33)
2) (:1)
Script execution resumed.
......
......@@ -4,13 +4,13 @@ breakpoint set before postMessage
paused at breakpoint
requested stepInto with breakOnAsyncCall flag
scheduled pause on async call
onmessage at iframe.js:0:20
onmessage at iframe.js:0:29
--postMessage--
(anonymous) at test.js:3:16
requested stepInto with breakOnAsyncCall flag
scheduled pause on async call
channel.port1.onmessage at test.js:4:30
channel.port1.onmessage at test.js:4:37
--postMessage--
onmessage at iframe.js:0:38
--postMessage--
......
......@@ -42,10 +42,6 @@
{callFrames, parent: asyncStackTrace, parentId: asyncStackTraceId},
debuggerId);
dp.Debugger.stepInto({breakOnAsyncCall: true});
({params: {asyncCallStackTraceId, callFrames}} =
await dp.Debugger.oncePaused());
testRunner.log('\nrequested stepInto with breakOnAsyncCall flag');
dp.Debugger.stepInto({breakOnAsyncCall: true});
({params: {asyncCallStackTraceId, callFrames}} =
......
......@@ -6,7 +6,7 @@ Run worker
Run stepInto with breakOnAsyncCall flag
Get scheduledAsyncStackId
Request pause on async task and resume
worker.onmessage at test.js:3:19
worker.onmessage at test.js:3:34
--postMessage--
(anonymous) at worker.js:0:0
--Worker Created--
......
......@@ -5,7 +5,7 @@ Run stepInto with breakOnAsyncCall flag
Get scheduledAsyncStackId
Setup worker session
Request pause on async task and run worker
onmessage at worker.js:0:12
onmessage at worker.js:0:27
--Worker.postMessage--
(anonymous) at test.js:3:7
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment