GitLab

Revert "Reland "Migrate away from deprecated RunLoop API""

This reverts commit d8d9405e.

Reason for revert:

Builder: Mac10.9 Tests (dbg) https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 started breaking in TwoClientPasswordsSyncTest.SetPassphraseAndThenSetupSync and this is the only sync change.

Sheriff notes say that this was reverted the first time for this exact test breakage. Please DO NOT RELAND until you ensure the test won't fail.

Original change's description:
> Reland "Migrate away from deprecated RunLoop API"
> 
> In this second attempt, we stick to QuitWhenIdle() for passwords, with
> no apparent legit reason. TODO added for further investigation.
> 
> This is a reland of 07edac9e
> Original change's description:
> > Migrate away from deprecated RunLoop API
> >
> > Instead, we keep around an instance of base::RunLoop and pass it
> > explicitly for Quit(), which makes sure the code quits the intended loop
> > and not a nested one.
> >
> > Bug: 783774
> > Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a
> > Reviewed-on: https://chromium-review.googlesource.com/784790
> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#519664}
> 
> TBR=pavely@chromium.org
> 
> Bug: 783774
> Change-Id: Ia93b738ad34e78289d938809f61e6c6d06c4bc80
> Reviewed-on: https://chromium-review.googlesource.com/793910
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520539}

TBR=pavely@chromium.org,mastiz@chromium.org

Change-Id: I1f45e1795eaa8d7a8aa22a7af6d87b5cb173ff0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783774
Reviewed-on: https://chromium-review.googlesource.com/801170Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520576}