Commit c0273bf9 authored by Nigel Tao's avatar Nigel Tao Committed by Commit Bot

Update Manifest::Location comment

Change-Id: I4ba329c49203a99a9d0d2bd0c14d67b629e9da36
Reviewed-on: https://chromium-review.googlesource.com/1170448Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582079}
parent 68947d74
...@@ -24,13 +24,24 @@ struct InstallWarning; ...@@ -24,13 +24,24 @@ struct InstallWarning;
// properties of the manifest using ManifestFeatureProvider. // properties of the manifest using ManifestFeatureProvider.
class Manifest { class Manifest {
public: public:
// What an extension was loaded from. // Historically, where an extension was loaded from, and whether an
// extension's files were inside or outside of the profile's directory. In
// modern usage, a Location can be thought of as the installation source:
// whether an extension was explicitly installed by the user (through the
// UI), or implicitly installed by other means. For example, enterprise
// policy, being part of Chrome per se (but implemented as an extension), or
// installed as a side effect of installing third party software.
//
// NOTE: These values are stored as integers in the preferences and used // NOTE: These values are stored as integers in the preferences and used
// in histograms so don't remove or reorder existing items. Just append // in histograms so don't remove or reorder existing items. Just append
// to the end. // to the end.
enum Location { enum Location {
INVALID_LOCATION, INVALID_LOCATION,
INTERNAL, // A crx file from the internal Extensions directory. INTERNAL, // A crx file from the internal Extensions directory. This
// includes extensions explicitly installed by the user. It also
// includes installed-by-default extensions that are not part of
// Chrome itself (and thus not a COMPONENT), but are part of a
// larger system (such as Chrome OS).
EXTERNAL_PREF, // A crx file from an external directory (via prefs). EXTERNAL_PREF, // A crx file from an external directory (via prefs).
EXTERNAL_REGISTRY, // A crx file from an external directory (via eg the EXTERNAL_REGISTRY, // A crx file from an external directory (via eg the
// registry on Windows). // registry on Windows).
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment