Commit c03263ee authored by Paul Lewis's avatar Paul Lewis Committed by Commit Bot

[DevTools] Fixes keyboard shortcuts for Mac

Bug: 1011638
Change-Id: I4930f3a0b5fd3de08bcfd52f6f68777bdb28ed80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845224Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703438}
parent 395569f3
...@@ -43,7 +43,7 @@ export default class KeyboardShortcut { ...@@ -43,7 +43,7 @@ export default class KeyboardShortcut {
if (typeof keyCode === 'string') { if (typeof keyCode === 'string') {
keyCode = keyCode.charCodeAt(0) - (/^[a-z]/.test(keyCode) ? 32 : 0); keyCode = keyCode.charCodeAt(0) - (/^[a-z]/.test(keyCode) ? 32 : 0);
} }
modifiers = modifiers || KeyboardShortcut.Modifiers.None; modifiers = modifiers || Modifiers.None;
return KeyboardShortcut._makeKeyFromCodeAndModifiers(keyCode, modifiers); return KeyboardShortcut._makeKeyFromCodeAndModifiers(keyCode, modifiers);
} }
...@@ -52,18 +52,18 @@ export default class KeyboardShortcut { ...@@ -52,18 +52,18 @@ export default class KeyboardShortcut {
* @return {number} * @return {number}
*/ */
static makeKeyFromEvent(keyboardEvent) { static makeKeyFromEvent(keyboardEvent) {
let modifiers = KeyboardShortcut.Modifiers.None; let modifiers = Modifiers.None;
if (keyboardEvent.shiftKey) { if (keyboardEvent.shiftKey) {
modifiers |= KeyboardShortcut.Modifiers.Shift; modifiers |= Modifiers.Shift;
} }
if (keyboardEvent.ctrlKey) { if (keyboardEvent.ctrlKey) {
modifiers |= KeyboardShortcut.Modifiers.Ctrl; modifiers |= Modifiers.Ctrl;
} }
if (keyboardEvent.altKey) { if (keyboardEvent.altKey) {
modifiers |= KeyboardShortcut.Modifiers.Alt; modifiers |= Modifiers.Alt;
} }
if (keyboardEvent.metaKey) { if (keyboardEvent.metaKey) {
modifiers |= KeyboardShortcut.Modifiers.Meta; modifiers |= Modifiers.Meta;
} }
// Use either a real or a synthetic keyCode (for events originating from extensions). // Use either a real or a synthetic keyCode (for events originating from extensions).
...@@ -77,7 +77,7 @@ export default class KeyboardShortcut { ...@@ -77,7 +77,7 @@ export default class KeyboardShortcut {
*/ */
static makeKeyFromEventIgnoringModifiers(keyboardEvent) { static makeKeyFromEventIgnoringModifiers(keyboardEvent) {
const keyCode = keyboardEvent.keyCode || keyboardEvent['__keyCode']; const keyCode = keyboardEvent.keyCode || keyboardEvent['__keyCode'];
return KeyboardShortcut._makeKeyFromCodeAndModifiers(keyCode, KeyboardShortcut.Modifiers.None); return KeyboardShortcut._makeKeyFromCodeAndModifiers(keyCode, Modifiers.None);
} }
/** /**
...@@ -117,8 +117,8 @@ export default class KeyboardShortcut { ...@@ -117,8 +117,8 @@ export default class KeyboardShortcut {
let modifiers = 0; let modifiers = 0;
let keyString; let keyString;
for (let i = 0; i < parts.length; ++i) { for (let i = 0; i < parts.length; ++i) {
if (typeof KeyboardShortcut.Modifiers[parts[i]] !== 'undefined') { if (typeof Modifiers[parts[i]] !== 'undefined') {
modifiers |= KeyboardShortcut.Modifiers[parts[i]]; modifiers |= Modifiers[parts[i]];
continue; continue;
} }
console.assert( console.assert(
...@@ -133,7 +133,7 @@ export default class KeyboardShortcut { ...@@ -133,7 +133,7 @@ export default class KeyboardShortcut {
const key = KeyboardShortcut.Keys[keyString] || KeyboardShortcut.KeyBindings[keyString]; const key = KeyboardShortcut.Keys[keyString] || KeyboardShortcut.KeyBindings[keyString];
if (key && key.shiftKey) { if (key && key.shiftKey) {
modifiers |= KeyboardShortcut.Modifiers.Shift; modifiers |= Modifiers.Shift;
} }
return KeyboardShortcut.makeDescriptor(key ? key : keyString, modifiers); return KeyboardShortcut.makeDescriptor(key ? key : keyString, modifiers);
} }
...@@ -184,7 +184,7 @@ export default class KeyboardShortcut { ...@@ -184,7 +184,7 @@ export default class KeyboardShortcut {
*/ */
static _modifiersToString(modifiers) { static _modifiersToString(modifiers) {
const isMac = Host.isMac(); const isMac = Host.isMac();
const m = KeyboardShortcut.Modifiers; const m = Modifiers;
const modifierNames = new Map([ const modifierNames = new Map([
[m.Ctrl, isMac ? 'Ctrl\u2004' : 'Ctrl\u200A+\u200A'], [m.Alt, isMac ? '\u2325\u2004' : 'Alt\u200A+\u200A'], [m.Ctrl, isMac ? 'Ctrl\u2004' : 'Ctrl\u200A+\u200A'], [m.Alt, isMac ? '\u2325\u2004' : 'Alt\u200A+\u200A'],
[m.Shift, isMac ? '\u21e7\u2004' : 'Shift\u200A+\u200A'], [m.Meta, isMac ? '\u2318\u2004' : 'Win\u200A+\u200A'] [m.Shift, isMac ? '\u21e7\u2004' : 'Shift\u200A+\u200A'], [m.Meta, isMac ? '\u2318\u2004' : 'Win\u200A+\u200A']
...@@ -281,11 +281,11 @@ export const Keys = { ...@@ -281,11 +281,11 @@ export const Keys = {
export const KeyBindings = {}; export const KeyBindings = {};
(function() { (function() {
for (const key in KeyboardShortcut.Keys) { for (const key in Keys) {
const descriptor = KeyboardShortcut.Keys[key]; const descriptor = Keys[key];
if (typeof descriptor === 'object' && descriptor['code']) { if (typeof descriptor === 'object' && descriptor['code']) {
const name = typeof descriptor['name'] === 'string' ? descriptor['name'] : key; const name = typeof descriptor['name'] === 'string' ? descriptor['name'] : key;
KeyboardShortcut.KeyBindings[name] = descriptor; KeyBindings[name] = descriptor;
} }
} }
})(); })();
...@@ -314,4 +314,4 @@ UI.KeyboardShortcut.KeyBindings = KeyBindings; ...@@ -314,4 +314,4 @@ UI.KeyboardShortcut.KeyBindings = KeyBindings;
UI.KeyboardShortcut.Key; UI.KeyboardShortcut.Key;
/** @typedef {!{key: number, name: string}} */ /** @typedef {!{key: number, name: string}} */
UI.KeyboardShortcut.Descriptor; UI.KeyboardShortcut.Descriptor;
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment