Commit c05aa05d authored by Carlos IL's avatar Carlos IL Committed by Commit Bot

Remove NavigateToInterstitialUrl function from RenderFrameHostImpl

This function was only used for overlay interstitial, and is dead code
now.

Bug: 1076947, 1077074
Change-Id: Ieb208b0c617852cc8f74402ffed89d02d4e7219a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202675
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769048}
parent c50a7196
......@@ -491,8 +491,7 @@ void LogCanCommitOriginAndUrlFailureReason(const std::string& failure_reason) {
url::Origin GetOriginForURLLoaderFactoryUnchecked(
NavigationRequest* navigation_request) {
// Return a safe opaque origin when there is no |navigation_request| (e.g.
// when RFHI::CommitNavigation is called via RFHI::NavigateToInterstitialURL).
// Return a safe opaque origin when there is no |navigation_request|
if (!navigation_request)
return url::Origin();
......@@ -5202,32 +5201,6 @@ CanCommitStatus RenderFrameHostImpl::CanCommitOriginAndUrl(
return CanCommitStatus::CAN_COMMIT_ORIGIN_AND_URL;
}
void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {
TRACE_EVENT1("navigation", "RenderFrameHostImpl::NavigateToInterstitialURL",
"frame_tree_node", frame_tree_node_->frame_tree_node_id());
DCHECK(data_url.SchemeIs(url::kDataScheme));
NavigationDownloadPolicy download_policy;
download_policy.SetDisallowed(NavigationDownloadType::kInterstitial);
auto common_params = mojom::CommonNavigationParams::New(
data_url, base::nullopt, blink::mojom::Referrer::New(),
ui::PAGE_TRANSITION_LINK, mojom::NavigationType::DIFFERENT_DOCUMENT,
download_policy, false, GURL(), GURL(), PREVIEWS_OFF,
base::TimeTicks::Now(), "GET", nullptr,
network::mojom::SourceLocation::New(),
false /* started_from_context_menu */, false /* has_user_gesture */,
CreateInitiatorCSPInfo(), std::vector<int>(), std::string(),
false /* is_history_navigation_in_new_child_frame */, base::TimeTicks());
CommitNavigation(nullptr /* navigation_request */, std::move(common_params),
CreateCommitNavigationParams(), nullptr /* response_head */,
mojo::ScopedDataPipeConsumerHandle(),
network::mojom::URLLoaderClientEndpointsPtr(), false,
base::nullopt, base::nullopt /* subresource_overrides */,
nullptr /* provider_info */,
base::UnguessableToken::Create() /* not traced */,
nullptr /* web_bundle_factory */);
}
void RenderFrameHostImpl::Stop() {
TRACE_EVENT1("navigation", "RenderFrameHostImpl::Stop", "frame_tree_node",
frame_tree_node_->frame_tree_node_id());
......
......@@ -694,9 +694,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
lifecycle_state_ == LifecycleState::kSpeculative;
}
// Navigates to an interstitial page represented by the provided data URL.
void NavigateToInterstitialURL(const GURL& data_url);
// Stop the load in progress.
void Stop();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment